Re: [Intel-gfx] [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API

2017-06-05 Thread Andy Shevchenko
On Mon, 2017-06-05 at 18:01 +0200, Christoph Hellwig wrote: > >   for (i = 0; i < NFIT_UUID_MAX; i++) > > - if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) == > > 0) > > + if (!guid_equal(to_nfit_uuid(i), (guid_t *)&spa- > > >range_guid)) > >   return i; >

Re: [Intel-gfx] [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API

2017-06-05 Thread Christoph Hellwig
> for (i = 0; i < NFIT_UUID_MAX; i++) > - if (memcmp(to_nfit_uuid(i), spa->range_guid, 16) == 0) > + if (!guid_equal(to_nfit_uuid(i), (guid_t *)&spa->range_guid)) > return i; I think this should be guid_equal without the "!" _

Re: [Intel-gfx] [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API

2017-06-01 Thread Dan Williams
On Wed, May 31, 2017 at 12:41 PM, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. > > Cc: Dan Williams > Signed-off-by: Andy Shevchenko > --- > drivers/

[Intel-gfx] [PATCH v2 1/5] acpi, nfit: Switch to use new generic UUID API

2017-05-31 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Cc: Dan Williams Signed-off-by: Andy Shevchenko --- drivers/acpi/nfit/core.c | 54 dr