Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: add warning for unidle GPU

2011-09-25 Thread Chris Wilson
On Sun, 25 Sep 2011 12:16:36 +0200, Daniel Vetter wrote: > Also it looks like this causes us to no properly idle the gpu on > suspend/resume. Might fix issues especially on gen2/3 where we put an > MI_WAIT in front of the flip, hence enlarging the window to up to 20 ms. This I happen to disagree

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: add warning for unidle GPU

2011-09-25 Thread Daniel Vetter
On Sat, Sep 24, 2011 at 03:23:04PM -0700, Ben Widawsky wrote: > When we attempt to idle the GPU we take a shortcut by checking if our > lists are empty and if so, avoid doing a synchronizing flush. The > warning will let us know if this assumption turns out to not be correct. > > Cc: Chris Wilson

[Intel-gfx] [PATCH v2 1/4] drm/i915: add warning for unidle GPU

2011-09-24 Thread Ben Widawsky
When we attempt to idle the GPU we take a shortcut by checking if our lists are empty and if so, avoid doing a synchronizing flush. The warning will let us know if this assumption turns out to not be correct. Cc: Chris Wilson Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem.c |