Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/vbt: Fix backlight parsing for VBT 234+

2020-10-07 Thread Matt Roper
On Wed, Oct 07, 2020 at 05:33:48PM -0700, Souza, Jose wrote: > On Wed, 2020-10-07 at 15:45 -0700, Matt Roper wrote: > > On Tue, Sep 29, 2020 at 03:34:17PM -0700, José Roberto de Souza wrote: > > > Child min_brightness is obsolete from VBT 234+, instead the new > > > min_brightness field in the main

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/vbt: Fix backlight parsing for VBT 234+

2020-10-07 Thread Souza, Jose
On Wed, 2020-10-07 at 15:45 -0700, Matt Roper wrote: > On Tue, Sep 29, 2020 at 03:34:17PM -0700, José Roberto de Souza wrote: > > Child min_brightness is obsolete from VBT 234+, instead the new > > min_brightness field in the main structure should be used. > > > > This new field is 16 bits wide, s

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/vbt: Fix backlight parsing for VBT 234+

2020-10-07 Thread Matt Roper
On Tue, Sep 29, 2020 at 03:34:17PM -0700, José Roberto de Souza wrote: > Child min_brightness is obsolete from VBT 234+, instead the new > min_brightness field in the main structure should be used. > > This new field is 16 bits wide, so backlight_precision_bits is needed > to check if value needs

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/vbt: Fix backlight parsing for VBT 234+

2020-10-06 Thread Souza, Jose
On Tue, 2020-10-06 at 12:04 +0300, Jani Nikula wrote: > On Tue, 29 Sep 2020, José Roberto de Souza wrote: > > Child min_brightness is obsolete from VBT 234+, instead the new > > min_brightness field in the main structure should be used. > > > > This new field is 16 bits wide, so backlight_precisi

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/vbt: Fix backlight parsing for VBT 234+

2020-10-06 Thread Jani Nikula
On Tue, 29 Sep 2020, José Roberto de Souza wrote: > Child min_brightness is obsolete from VBT 234+, instead the new > min_brightness field in the main structure should be used. > > This new field is 16 bits wide, so backlight_precision_bits is needed > to check if value needs to be scaled down but

[Intel-gfx] [PATCH v2 1/3] drm/i915/vbt: Fix backlight parsing for VBT 234+

2020-09-29 Thread José Roberto de Souza
Child min_brightness is obsolete from VBT 234+, instead the new min_brightness field in the main structure should be used. This new field is 16 bits wide, so backlight_precision_bits is needed to check if value needs to be scaled down but it is only available in VBT 236+ so working around it by us