Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: add render state initialization

2014-05-06 Thread Mika Kuoppala
Chris Wilson writes: > On Tue, May 06, 2014 at 04:26:05PM +0300, Mika Kuoppala wrote: >> HW guys say that it is not a cool idea to let device >> go into rc6 without proper 3d pipeline state. > > * shrug > > What's improper 3d state and what prevents userspace from triggering > badness later? I w

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: add render state initialization

2014-05-06 Thread Chris Wilson
On Tue, May 06, 2014 at 04:26:05PM +0300, Mika Kuoppala wrote: > HW guys say that it is not a cool idea to let device > go into rc6 without proper 3d pipeline state. * shrug What's improper 3d state and what prevents userspace from triggering badness later? The only problem I see in the patch is

[Intel-gfx] [PATCH v2 1/2] drm/i915: add render state initialization

2014-05-06 Thread Mika Kuoppala
HW guys say that it is not a cool idea to let device go into rc6 without proper 3d pipeline state. For each new uninitialized context, generate a valid null render state to be run on context creation. This patch introduces a skeleton with empty states. v2: - No need to vmap (Chris Wilson) -