Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-25 Thread Lionel Landwerlin
On 25/07/17 05:26, Zhenyu Wang wrote: On 2017.07.21 14:01:01 +0100, Lionel Landwerlin wrote: I think Chris' comments show this isn't actually tested. It turned out that's true...so currently Pengyuan just tried to filter by exposed vGPU ctx_hw_id with global mode in gputop. Would that be ok wit

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-24 Thread Zhenyu Wang
On 2017.07.21 14:01:01 +0100, Lionel Landwerlin wrote: > I think Chris' comments show this isn't actually tested. It turned out that's true...so currently Pengyuan just tried to filter by exposed vGPU ctx_hw_id with global mode in gputop. Would that be ok with you? If yes, then we don't need i915

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-21 Thread Lionel Landwerlin
I think Chris' comments show this isn't actually tested. Can you please write at least one test case for igt ? We have a pretty long list of patches that need to land (still need review on some patches). I would recommend you base you patches on this : https://github.com/djdeath/intel-gpu-tool

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-21 Thread Chris Wilson
Quoting Zhenyu Wang (2017-07-19 06:39:48) > +static struct i915_gem_context * > +lookup_context_hw_id(struct drm_i915_private *dev_priv, unsigned int hw_id) > +{ > + struct i915_gem_context *ctx; > + int ret; > + > + ret = i915_mutex_lock_interruptible(&dev_priv->drm); > + i

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-21 Thread Lionel Landwerlin
Just a small nit down there. On 19/07/17 06:39, Zhenyu Wang wrote: In order to support profiling for special context e.g vGPU context, we can expose vGPU context hw id and enable i915 perf property to get target context for profiling. This adds new perf property to assign target context with hw

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add perf property support for context HW id

2017-07-18 Thread Zhenyu Wang
In order to support profiling for special context e.g vGPU context, we can expose vGPU context hw id and enable i915 perf property to get target context for profiling. This adds new perf property to assign target context with hw id. Jiao Pengyuan has helped to fix context reference bug in original