Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-11-28 Thread Daniele Ceraolo Spurio
On 27/11/2018 11:34, Daniele Ceraolo Spurio wrote: On 26/11/2018 06:51, Michal Wajdeczko wrote: On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio wrote: /snip/ diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h index 8382d591c784..1a853c

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-11-27 Thread Daniele Ceraolo Spurio
On 26/11/2018 06:51, Michal Wajdeczko wrote: On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio wrote: /snip/ diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h index 8382d591c784..1a853cc627e3 100644 --- a/drivers/gpu/drm/i915/intel_guc_fwi

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-11-26 Thread Michal Wajdeczko
On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio wrote: /snip/ diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h index 8382d591c784..1a853cc627e3 100644 --- a/drivers/gpu/drm/i915/intel_guc_fwif.h +++ b/drivers/gpu/drm/i915/intel_guc_fwif.

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-17 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-10-17 17:40:50) > On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio > wrote: > > > The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC > > FW and then return, so waiting on the H2G is not enough to guarantee > > GuC is done. > > When al

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-17 Thread Michal Wajdeczko
On Wed, 17 Oct 2018 00:46:47 +0200, Daniele Ceraolo Spurio wrote: The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC FW and then return, so waiting on the H2G is not enough to guarantee GuC is done. When all the processing is done, GuC writes 0 to scratch register 14, so w

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: fix GuC suspend/resume

2018-10-16 Thread Daniele Ceraolo Spurio
The ENTER/EXIT_S_STATE actions queue the save/restore operation in GuC FW and then return, so waiting on the H2G is not enough to guarantee GuC is done. When all the processing is done, GuC writes 0 to scratch register 14, so we can poll on that. Note that GuC does not ensure that the value in the