Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-06 Thread Sripada, Radhakrishna
> -Original Message- > From: Andi Shyti > Sent: Friday, March 3, 2023 7:24 PM > To: Sripada, Radhakrishna > Cc: Andi Shyti ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org; Tvrtko Ursulin ; > Andi Shyti ; Patelczyk, Maciej > ; Wajdeczko, Michal > > Subject: Re:

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-03 Thread Andi Shyti
On Wed, Mar 01, 2023 at 09:35:33PM +, Sripada, Radhakrishna wrote: > I am not sure if Tiles is appropriate usage here. Since MTL does not have the > concept of tiles. > Shouldn't we be using gt instead of tile in our usage? > > With s/tile/gt/g, > Reviewed-by: Radhakrishna Sripada Just one

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Andi Shyti
> I am not sure if Tiles is appropriate usage here. Since MTL does not have the > concept of tiles. > Shouldn't we be using gt instead of tile in our usage? > > With s/tile/gt/g, > Reviewed-by: Radhakrishna Sripada yes, GT is preferred to tile, generally. Thanks for the review, I will change t

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Sripada, Radhakrishna
I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles. Shouldn't we be using gt instead of tile in our usage? With s/tile/gt/g, Reviewed-by: Radhakrishna Sripada > -Original Message- > From: dri-devel On Behalf Of Andi > Shyti > Sent: Wednesday

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Sripada, Radhakrishna
> -Original Message- > From: dri-devel On Behalf Of Andi > Shyti > Sent: Wednesday, March 1, 2023 3:03 AM > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org > Cc: Tvrtko Ursulin ; Andi Shyti > ; Patelczyk, Maciej ; Andi > Shyti ; Wajdeczko, Michal > > Subject: [PATCH

[Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files

2023-03-01 Thread Andi Shyti
To support multi-GT configurations, we need to generate independent debug files for each GT. To achieve this create a separate directory for each GT under the debugfs directory. For instance, in a system with two tiles, the debugfs structure would look like this: /sys/kernel/debug/dri