Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Remove connectors_active from intel_dp.c.

2015-07-30 Thread Ander Conselvan De Oliveira
On Thu, 2015-07-30 at 08:54 +0200, Maarten Lankhorst wrote: > Op 29-07-15 om 15:26 schreef Ander Conselvan De Oliveira: > > On Mon, 2015-07-27 at 14:35 +0200, Maarten Lankhorst wrote: > > > Now that everything's atomic, checking encoder->base.crtc is enough. > > Don't you need to check encoder->bas

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Remove connectors_active from intel_dp.c.

2015-07-29 Thread Maarten Lankhorst
Op 29-07-15 om 15:26 schreef Ander Conselvan De Oliveira: > On Mon, 2015-07-27 at 14:35 +0200, Maarten Lankhorst wrote: >> Now that everything's atomic, checking encoder->base.crtc is enough. > Don't you need to check encoder->base.crtc->state->active too? Not sure, I think stealing a encoder being

Re: [Intel-gfx] [PATCH v2 09/12] drm/i915: Remove connectors_active from intel_dp.c.

2015-07-29 Thread Ander Conselvan De Oliveira
On Mon, 2015-07-27 at 14:35 +0200, Maarten Lankhorst wrote: > Now that everything's atomic, checking encoder->base.crtc is enough. Don't you need to check encoder->base.crtc->state->active too? > Cc: Ville Syrjälä > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_dp.c | 7 +

[Intel-gfx] [PATCH v2 09/12] drm/i915: Remove connectors_active from intel_dp.c.

2015-07-27 Thread Maarten Lankhorst
Now that everything's atomic, checking encoder->base.crtc is enough. Cc: Ville Syrjälä Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_dp.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.