Re: [Intel-gfx] [PATCH v2 08/22] drm/i915/rkl: Add power well support

2020-05-06 Thread Anshuman Gupta
On 2020-05-05 at 19:09:54 +0300, Imre Deak wrote: > On Tue, May 05, 2020 at 07:39:04AM -0700, Matt Roper wrote: > > On Tue, May 05, 2020 at 10:20:58AM +0530, Anshuman Gupta wrote: > > > On 2020-05-04 at 15:52:13 -0700, Matt Roper wrote: > > > > RKL power wells are similar to TGL power wells, but ha

Re: [Intel-gfx] [PATCH v2 08/22] drm/i915/rkl: Add power well support

2020-05-05 Thread Imre Deak
On Tue, May 05, 2020 at 07:39:04AM -0700, Matt Roper wrote: > On Tue, May 05, 2020 at 10:20:58AM +0530, Anshuman Gupta wrote: > > On 2020-05-04 at 15:52:13 -0700, Matt Roper wrote: > > > RKL power wells are similar to TGL power wells, but have some important > > > differences: > > > > > > * PG1 n

Re: [Intel-gfx] [PATCH v2 08/22] drm/i915/rkl: Add power well support

2020-05-05 Thread Matt Roper
On Tue, May 05, 2020 at 10:20:58AM +0530, Anshuman Gupta wrote: > On 2020-05-04 at 15:52:13 -0700, Matt Roper wrote: > > RKL power wells are similar to TGL power wells, but have some important > > differences: > > > > * PG1 now has pipe A's VDSC (rather than sticking it in PG2) > > * PG2 no long

Re: [Intel-gfx] [PATCH v2 08/22] drm/i915/rkl: Add power well support

2020-05-04 Thread Anshuman Gupta
On 2020-05-04 at 15:52:13 -0700, Matt Roper wrote: > RKL power wells are similar to TGL power wells, but have some important > differences: > > * PG1 now has pipe A's VDSC (rather than sticking it in PG2) > * PG2 no longer exists > * DDI-C (aka TC-1) moves from PG1 -> PG3 > * PG5 no longer exi

[Intel-gfx] [PATCH v2 08/22] drm/i915/rkl: Add power well support

2020-05-04 Thread Matt Roper
RKL power wells are similar to TGL power wells, but have some important differences: * PG1 now has pipe A's VDSC (rather than sticking it in PG2) * PG2 no longer exists * DDI-C (aka TC-1) moves from PG1 -> PG3 * PG5 no longer exists due to the lack of a fourth pipe Also note that what we refe