Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-05 Thread Maarten Lankhorst
Op 04-10-18 om 17:24 schreef Ville Syrjälä: > On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote: >> Op 04-10-18 om 14:57 schreef Ville Syrjälä: >>> On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: Do not rely on crtc->config any more. Remove the assertion from

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-05 Thread Maarten Lankhorst
Op 04-10-18 om 17:24 schreef Ville Syrjälä: > On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote: >> Op 04-10-18 om 14:57 schreef Ville Syrjälä: >>> On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: Do not rely on crtc->config any more. Remove the assertion from

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-04 Thread Ville Syrjälä
On Thu, Oct 04, 2018 at 03:25:42PM +0200, Maarten Lankhorst wrote: > Op 04-10-18 om 14:57 schreef Ville Syrjälä: > > On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: > >> Do not rely on crtc->config any more. Remove the assertion from > >> ibx_pch_dpll_disable, because we the dpll

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-04 Thread Maarten Lankhorst
Op 04-10-18 om 14:57 schreef Ville Syrjälä: > On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: >> Do not rely on crtc->config any more. Remove the assertion from >> ibx_pch_dpll_disable, because we the dpll state tracking should >> already handle this case correctly. >> >> Signed-

Re: [Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-04 Thread Ville Syrjälä
On Thu, Oct 04, 2018 at 11:45:59AM +0200, Maarten Lankhorst wrote: > Do not rely on crtc->config any more. Remove the assertion from > ibx_pch_dpll_disable, because we the dpll state tracking should > already handle this case correctly. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Ville Sy

[Intel-gfx] [PATCH v2 08/13] drm/i915: Make shared dpll functions take crtc_state

2018-10-04 Thread Maarten Lankhorst
Do not rely on crtc->config any more. Remove the assertion from ibx_pch_dpll_disable, because we the dpll state tracking should already handle this case correctly. Signed-off-by: Maarten Lankhorst Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 14 ++-- drivers/gp