Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-31 Thread Ben Widawsky
On Sat, Mar 30, 2013 at 06:02:16PM +, Chris Wilson wrote: > On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: > > Update: Squashes a couple commits to avoid potential hang if > > git bisecting. No other changes from v1. > > I'm seeing another variation (both in lp and reporte

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-30 Thread Chris Wilson
On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: > Update: Squashes a couple commits to avoid potential hang if > git bisecting. No other changes from v1. I'm seeing another variation (both in lp and reported by Ben) whereby it appears that the open("/dev/dri/card0") fails and s

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-20 Thread Chris Wilson
On Wed, Mar 20, 2013 at 09:40:04AM +0100, Maarten Lankhorst wrote: > Is the drmSetInterfaceVersion call really needed here? If I look at > DRM_IOCTL_GET_UNIQUE, > I don't see any requirement of drm master or anything, so it looks to me like > for this specific race > the drmSetInterfaceVersion ca

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-20 Thread Maarten Lankhorst
Op 20-03-13 09:40, Maarten Lankhorst schreef: > Hey, > > Op 19-03-13 22:13, Chris Wilson schreef: >> On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote: >>> The drmSetMaster call is needed, but the spinning is really just waiting >>> for the workqueue to run. >>> >>> bryce's patch n

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-20 Thread Maarten Lankhorst
Hey, Op 19-03-13 22:13, Chris Wilson schreef: > On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote: >> The drmSetMaster call is needed, but the spinning is really just waiting for >> the workqueue to run. >> >> bryce's patch never worked, it just caused it to try drmsetinterfacever

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Chris Wilson
On Tue, Mar 19, 2013 at 11:50:47AM +0100, Maarten Lankhorst wrote: > The drmSetMaster call is needed, but the spinning is really just waiting for > the workqueue to run. > > bryce's patch never worked, it just caused it to try drmsetinterfaceversion > for a few seconds before timing out. That ca

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Maarten Lankhorst
Op 19-03-13 12:10, Dave Airlie schreef: >> Because of the delayed fput in recent kernels, it is possible for plymouth >> to exit and not drop master right away. >> It's put onto a workqueue to be freed slightly later. Xorg-server starts in >> the meantime, opens a fd, but because the fd >> hasn't

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Maarten Lankhorst
Hey, Op 19-03-13 11:27, Chris Wilson schreef: > On Tue, Mar 19, 2013 at 11:02:14AM +0100, Maarten Lankhorst wrote: >> Hey, >> >> Op 19-03-13 10:21, Chris Wilson schreef: >>> On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: Update: Squashes a couple commits to avoid potential

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Maarten Lankhorst
Hey, Op 19-03-13 10:21, Chris Wilson schreef: > On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: >> Update: Squashes a couple commits to avoid potential hang if >> git bisecting. No other changes from v1. > I'd probably drop the last EAGAIN patch as that is part of the libdrm >

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Dave Airlie
> > Because of the delayed fput in recent kernels, it is possible for plymouth to > exit and not drop master right away. > It's put onto a workqueue to be freed slightly later. Xorg-server starts in > the meantime, opens a fd, but because the fd > hasn't been closed by plymouth yet, it didn't get

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Chris Wilson
On Tue, Mar 19, 2013 at 11:02:14AM +0100, Maarten Lankhorst wrote: > Hey, > > Op 19-03-13 10:21, Chris Wilson schreef: > > On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: > >> Update: Squashes a couple commits to avoid potential hang if > >> git bisecting. No other changes from

Re: [Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-19 Thread Chris Wilson
On Mon, Mar 18, 2013 at 01:51:44PM -0700, Bryce Harrington wrote: > Update: Squashes a couple commits to avoid potential hang if > git bisecting. No other changes from v1. I'd probably drop the last EAGAIN patch as that is part of the libdrm API, but other than that it looks to be a reasonably s

[Intel-gfx] [PATCH v2 0/7] xfree86: Handle drm race condition

2013-03-18 Thread Bryce Harrington
Update: Squashes a couple commits to avoid potential hang if git bisecting. No other changes from v1. When starting up (on Ubuntu), X can hit an error trying to set the version on the drm device. We believe this is a race with plymouth (or the kernel), since adding some delay to the boot r