Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-28 Thread Lucas De Marchi
On Tue, Nov 27, 2018 at 04:19:23PM -0800, Rodrigo Vivi wrote: > > Then on the question of IS_ prefix or not, I don't feel very strongly about > > it. IS_ has a nice parallel with HAS_ and IS_platform, but I agree it > > doesn't look the prettiest (IS_GT_GEN). So don't know, whatever the vote > > en

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-27 Thread Rodrigo Vivi
On Tue, Nov 27, 2018 at 11:35:54AM +, Tvrtko Ursulin wrote: > > On 27/11/2018 09:36, Lucas De Marchi wrote: > > On Tue, Nov 27, 2018 at 10:37:21AM +0200, Jani Nikula wrote: > > > On Mon, 26 Nov 2018, Rodrigo Vivi wrote: > > > > On Thu, Nov 22, 2018 at 08:54:30AM +, Tvrtko Ursulin wrote: >

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-27 Thread Tvrtko Ursulin
On 27/11/2018 09:36, Lucas De Marchi wrote: On Tue, Nov 27, 2018 at 10:37:21AM +0200, Jani Nikula wrote: On Mon, 26 Nov 2018, Rodrigo Vivi wrote: On Thu, Nov 22, 2018 at 08:54:30AM +, Tvrtko Ursulin wrote: On 21/11/2018 22:19, Rodrigo Vivi wrote: On Mon, Nov 19, 2018 at 02:20:55PM -08

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-27 Thread Lucas De Marchi
On Tue, Nov 27, 2018 at 10:37:21AM +0200, Jani Nikula wrote: > On Mon, 26 Nov 2018, Rodrigo Vivi wrote: > > On Thu, Nov 22, 2018 at 08:54:30AM +, Tvrtko Ursulin wrote: > >> > >> > >> On 21/11/2018 22:19, Rodrigo Vivi wrote: > >> > On Mon, Nov 19, 2018 at 02:20:55PM -0800, Lucas De Marchi wro

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-27 Thread Jani Nikula
On Mon, 26 Nov 2018, Rodrigo Vivi wrote: > On Thu, Nov 22, 2018 at 08:54:30AM +, Tvrtko Ursulin wrote: >> >> >> On 21/11/2018 22:19, Rodrigo Vivi wrote: >> > On Mon, Nov 19, 2018 at 02:20:55PM -0800, Lucas De Marchi wrote: >> > > On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-26 Thread Rodrigo Vivi
On Thu, Nov 22, 2018 at 08:54:30AM +, Tvrtko Ursulin wrote: > > > On 21/11/2018 22:19, Rodrigo Vivi wrote: > > On Mon, Nov 19, 2018 at 02:20:55PM -0800, Lucas De Marchi wrote: > > > On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: > > > > > > > > On 08/11/2018 00:57, Lucas De

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-23 Thread Jani Nikula
On Mon, 19 Nov 2018, Lucas De Marchi wrote: > On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: >> Don't know, it's my opinion at least and more people are welcome to chime in >> with theirs. > > Any others to chime in on this? Jani, Ville, Rodrigo? Please hold until all aspects hav

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-22 Thread Tvrtko Ursulin
On 21/11/2018 22:19, Rodrigo Vivi wrote: On Mon, Nov 19, 2018 at 02:20:55PM -0800, Lucas De Marchi wrote: On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: On 08/11/2018 00:57, Lucas De Marchi wrote: On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: On 06/11/20

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-21 Thread Rodrigo Vivi
On Mon, Nov 19, 2018 at 02:20:55PM -0800, Lucas De Marchi wrote: > On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: > > > > On 08/11/2018 00:57, Lucas De Marchi wrote: > > > On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: > > > > > > > > On 06/11/2018 21:51, Lucas D

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-20 Thread Tvrtko Ursulin
On 19/11/2018 22:20, Lucas De Marchi wrote: On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: [snip] So are you against changing the == to use the macros, changing the >=, >, <, <=, or all of them? Definitely not all of them. Just plain if ladders I think are definitely more

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-19 Thread Lucas De Marchi
On Thu, Nov 08, 2018 at 11:23:46AM +, Tvrtko Ursulin wrote: > > On 08/11/2018 00:57, Lucas De Marchi wrote: > > On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: > > > > > > On 06/11/2018 21:51, Lucas De Marchi wrote: > > > > This is the second version of the series trying to ma

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-08 Thread Tvrtko Ursulin
On 08/11/2018 00:57, Lucas De Marchi wrote: On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: On 06/11/2018 21:51, Lucas De Marchi wrote: This is the second version of the series trying to make GEN checks more similar. These or roughly the changes from v1: - We don't have a sin

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-07 Thread Lucas De Marchi
On Wed, Nov 07, 2018 at 10:05:19AM +, Tvrtko Ursulin wrote: > > On 06/11/2018 21:51, Lucas De Marchi wrote: > > This is the second version of the series trying to make GEN checks > > more similar. These or roughly the changes from v1: > > > > - We don't have a single macro receiving 2 or 3 pa

Re: [Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-07 Thread Tvrtko Ursulin
On 06/11/2018 21:51, Lucas De Marchi wrote: This is the second version of the series trying to make GEN checks more similar. These or roughly the changes from v1: - We don't have a single macro receiving 2 or 3 parameters. Now there is GT_GEN_RANGE(), and GT_GEN(). The firs is the conversion

[Intel-gfx] [PATCH v2 0/7] Make GEN macros more similar

2018-11-06 Thread Lucas De Marchi
This is the second version of the series trying to make GEN checks more similar. These or roughly the changes from v1: - We don't have a single macro receiving 2 or 3 parameters. Now there is GT_GEN_RANGE(), and GT_GEN(). The firs is the conversion from IS_GEN() while the second is the convers