Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: introduce macros to define register contents

2019-02-27 Thread Chris Wilson
Quoting Jani Nikula (2019-02-27 11:01:58) > On Thu, 17 Jan 2019, Chris Wilson wrote: > > Quoting Jani Nikula (2019-01-17 12:13:59) > >> The v1 [1] kind of died down because the FIELD_PREP() build-time checks > >> were lost as it didn't evaluate to integer constant expression. I looked > >> at this

Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: introduce macros to define register contents

2019-02-27 Thread Jani Nikula
On Thu, 17 Jan 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-01-17 12:13:59) >> The v1 [1] kind of died down because the FIELD_PREP() build-time checks >> were lost as it didn't evaluate to integer constant expression. I looked >> at this again, and managed to include the checks in the loc

Re: [Intel-gfx] [PATCH v2 0/4] drm/i915: introduce macros to define register contents

2019-01-17 Thread Chris Wilson
Quoting Jani Nikula (2019-01-17 12:13:59) > The v1 [1] kind of died down because the FIELD_PREP() build-time checks > were lost as it didn't evaluate to integer constant expression. I looked > at this again, and managed to include the checks in the local copy by > using BUILD_BUG_ON_ZERO() instead.

[Intel-gfx] [PATCH v2 0/4] drm/i915: introduce macros to define register contents

2019-01-17 Thread Jani Nikula
The v1 [1] kind of died down because the FIELD_PREP() build-time checks were lost as it didn't evaluate to integer constant expression. I looked at this again, and managed to include the checks in the local copy by using BUILD_BUG_ON_ZERO() instead. On the naming bikeshedding department, I noticed