Re: [Intel-gfx] [PATCH v2] drm/i915: stop using swiotlb

2022-07-22 Thread Robert Beckett
On 22/07/2022 16:03, Christoph Hellwig wrote: + return max_t(size_t, UINT_MAX, dma_max_mapping_size(dev)); Shouldn't this be a min? eugh! yes. Stand by for v3

Re: [Intel-gfx] [PATCH v2] drm/i915: stop using swiotlb

2022-07-22 Thread Christoph Hellwig
> + return max_t(size_t, UINT_MAX, dma_max_mapping_size(dev)); Shouldn't this be a min?

[Intel-gfx] [PATCH v2] drm/i915: stop using swiotlb

2022-07-22 Thread Robert Beckett
Calling swiotlb functions directly is nowadays considered harmful. See https://lore.kernel.org/intel-gfx/20220711082614.ga29...@lst.de/ Replace swiotlb_max_segment() calls with dma_max_mapping_size(). In i915_gem_object_get_pages_internal() no longer consider max_segment only if CONFIG_SWIOTLB is