Re: [Intel-gfx] [PATCH v2] drm/i915: set scanout buffer as uncached on Sandybridge

2010-10-28 Thread Chris Wilson
On Thu, 28 Oct 2010 14:16:09 +0800, Zhenyu Wang wrote: > + ret = i915_gem_object_enable_scanout(obj); > + if (ret) { > + kfree(intel_fb); > + return ERR_PTR(ret); > + } We need to introduce a mutex_lock here. I wonder whether it is truly worth it. Yes, user spa

[Intel-gfx] [PATCH v2] drm/i915: set scanout buffer as uncached on Sandybridge

2010-10-27 Thread Zhenyu Wang
Display engine on Sandybridge is not coherent with LLC, so try to always bind display buffer as uncached on Sandybridge. Old AGP_USER_MEMORY is bound as uncached by default, as Sandybridge buffer would try to live in LLC with CPU as possible, so it uses new flag AGP_USER_UNCACHED_MEMORY for uncache