Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Ville Syrjälä
On Mon, Apr 09, 2018 at 03:11:38PM -0700, Kumar, Abhay wrote: > > > On 4/9/2018 3:33 AM, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 04:47:08PM +0300, Jani Nikula wrote: > >> On Thu, 05 Apr 2018, Abhay Kumar wrote: > >>> In glk when device boots with 1366x768 panel, HDA codec doesn't comeup

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Ville Syrjälä
On Tue, Apr 10, 2018 at 08:00:10PM -0700, Kumar, Abhay wrote: > > > On 4/10/2018 1:49 AM, Nikula, Jani wrote: > > On Tue, 10 Apr 2018, Jani Nikula wrote: > >> On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: > >>> Dynamic cdclk is disabled in BIOS/GOP hence gop makes it to highest > >>> clock i.e 316

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Kumar, Abhay
On 4/10/2018 1:49 AM, Nikula, Jani wrote: On Tue, 10 Apr 2018, Jani Nikula wrote: On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: Dynamic cdclk is disabled in BIOS/GOP hence gop makes it to highest clock i.e 316.8. Will attach logs with drm debug enabled in bug. I am also inclined towards 192 wh

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Jani Nikula
On Tue, 10 Apr 2018, Jani Nikula wrote: > On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: >> Dynamic cdclk is disabled in BIOS/GOP hence gop makes it to highest >> clock i.e 316.8. Will attach logs with drm debug enabled in bug. >> I am also inclined towards 192 which will make max cdclk.. > > Please

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Jani Nikula
On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: > Dynamic cdclk is disabled in BIOS/GOP hence gop makes it to highest > clock i.e 316.8. Will attach logs with drm debug enabled in bug. > I am also inclined towards 192 which will make max cdclk.. Please also attach /sys/kernel/debug/dri/0/i915_vbt to

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-09 Thread Kumar, Abhay
On 4/9/2018 3:33 AM, Ville Syrjälä wrote: On Fri, Apr 06, 2018 at 04:47:08PM +0300, Jani Nikula wrote: On Thu, 05 Apr 2018, Abhay Kumar wrote: In glk when device boots with 1366x768 panel, HDA codec doesn't comeup. This result in no audio forever as cdclk is < 96Mhz. This chagne will ensure

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-09 Thread Ville Syrjälä
On Fri, Apr 06, 2018 at 04:47:08PM +0300, Jani Nikula wrote: > On Thu, 05 Apr 2018, Abhay Kumar wrote: > > In glk when device boots with 1366x768 panel, HDA codec doesn't comeup. > > This result in no audio forever as cdclk is < 96Mhz. > > This chagne will ensure CD clock to be twice of BCLK. >

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-06 Thread Jani Nikula
On Thu, 05 Apr 2018, Abhay Kumar wrote: > In glk when device boots with 1366x768 panel, HDA codec doesn't comeup. > This result in no audio forever as cdclk is < 96Mhz. > This chagne will ensure CD clock to be twice of BCLK. In short, we can't poke around CDCLK like this. It needs a full modeset

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-06 Thread kbuild test robot
Hi Abhay, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on v4.16 next-20180405] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

[Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-05 Thread Abhay Kumar
In glk when device boots with 1366x768 panel, HDA codec doesn't comeup. This result in no audio forever as cdclk is < 96Mhz. This chagne will ensure CD clock to be twice of BCLK. v2: - Address comment (Jani) - New design approach Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102

[Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-05 Thread Abhay Kumar
In glk when device boots with 1366x768 panel, HDA codec doesn't comeup. This result in no audio forever as cdclk is < 96Mhz. This chagne will ensure CD clock to be twice of BCLK. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102937 Signed-off-by: Abhay Kumar --- drivers/gpu/drm/i915/in