Re: [Intel-gfx] [PATCH v2] drm/i915: Small compaction of the engine init code

2016-06-23 Thread Chris Wilson
On Thu, Jun 23, 2016 at 11:26:27AM +0100, Tvrtko Ursulin wrote: > > On 22/06/16 17:59, Chris Wilson wrote: > >On Wed, Jun 22, 2016 at 05:35:48PM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Effectively removes one layer of indirection between the mask of > >>possible engines and

Re: [Intel-gfx] [PATCH v2] drm/i915: Small compaction of the engine init code

2016-06-23 Thread Tvrtko Ursulin
On 22/06/16 17:59, Chris Wilson wrote: On Wed, Jun 22, 2016 at 05:35:48PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Effectively removes one layer of indirection between the mask of possible engines and the engine constructors. Instead of spelling out in code the mapping of HAS_ to con

Re: [Intel-gfx] [PATCH v2] drm/i915: Small compaction of the engine init code

2016-06-22 Thread Chris Wilson
On Wed, Jun 22, 2016 at 05:35:48PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Effectively removes one layer of indirection between the mask of > possible engines and the engine constructors. Instead of spelling > out in code the mapping of HAS_ to constructors, makes > more use of th

[Intel-gfx] [PATCH v2] drm/i915: Small compaction of the engine init code

2016-06-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Effectively removes one layer of indirection between the mask of possible engines and the engine constructors. Instead of spelling out in code the mapping of HAS_ to constructors, makes more use of the recently added data driven approach by putting engine constructor vfuncs i