Re: [Intel-gfx] [PATCH v2] drm/i915: GEM_WARN_ON considered harmful

2018-10-17 Thread Lis, Tomasz
On 2018-10-12 08:31, Tvrtko Ursulin wrote: From: Tvrtko Ursulin GEM_WARN_ON currently has dangerous semantics where it is completely compiled out on !GEM_DEBUG builds. This can leave users who expect it to be more like a WARN_ON, just without a warning in non-debug builds, in complete ignoran

[Intel-gfx] [PATCH v2] drm/i915: GEM_WARN_ON considered harmful

2018-10-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin GEM_WARN_ON currently has dangerous semantics where it is completely compiled out on !GEM_DEBUG builds. This can leave users who expect it to be more like a WARN_ON, just without a warning in non-debug builds, in complete ignorance. Another gotcha with it is that it cannot b