Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-21 Thread Jason A. Donenfeld
On Tue, Apr 21, 2020 at 09:38:09AM -0700, Sultan Alsawaf wrote: > Why hasn't this bug got any attention: > https://gitlab.freedesktop.org/drm/intel/issues/1412 > > That seems like a showstopper. Indeed, pretty shocking. It's worth mentioning that the reporter of said bug, after significant time h

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-21 Thread Sultan Alsawaf
On Tue, Apr 21, 2020 at 11:04:13AM +0300, Joonas Lahtinen wrote: > Quoting Sultan Alsawaf (2020-04-20 18:42:16) > > On Mon, Apr 20, 2020 at 12:02:39PM +0300, Joonas Lahtinen wrote: > > > I think the the patch should be dropped for now before the issue is > > > properly addressed. Either by backport

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-21 Thread Joonas Lahtinen
Quoting Sultan Alsawaf (2020-04-20 18:42:16) > On Mon, Apr 20, 2020 at 12:02:39PM +0300, Joonas Lahtinen wrote: > > I think the the patch should be dropped for now before the issue is > > properly addressed. Either by backporting the mainline fixes or if > > those are too big and there indeed is a

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-20 Thread Sultan Alsawaf
On Mon, Apr 20, 2020 at 12:02:39PM +0300, Joonas Lahtinen wrote: > I think the the patch should be dropped for now before the issue is > properly addressed. Either by backporting the mainline fixes or if > those are too big and there indeed is a smaller alternative patch > that is properly reviewed

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-20 Thread Joonas Lahtinen
Quoting Greg KH (2020-04-14 11:23:44) > On Tue, Apr 14, 2020 at 09:15:07AM +0100, Chris Wilson wrote: > > Quoting Greg KH (2020-04-11 12:39:57) > > > On Fri, Apr 10, 2020 at 07:17:38AM -0700, Sultan Alsawaf wrote: > > > > On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > > > > > On Tue, Ap

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-14 Thread Sultan Alsawaf
On Tue, Apr 14, 2020 at 09:15:07AM +0100, Chris Wilson wrote: > The patch does not fix a deadlock. Greg, this patch is not a backport of > a bugfix, why is it in stable? > -Chris Here's the deadlock this supposedly doesn't fix: INFO: task kswapd0:178 blocked for more than 122 seconds. Tainte

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-14 Thread Greg KH
On Tue, Apr 14, 2020 at 09:15:07AM +0100, Chris Wilson wrote: > Quoting Greg KH (2020-04-11 12:39:57) > > On Fri, Apr 10, 2020 at 07:17:38AM -0700, Sultan Alsawaf wrote: > > > On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > > > > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf w

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-14 Thread Chris Wilson
Quoting Greg KH (2020-04-11 12:39:57) > On Fri, Apr 10, 2020 at 07:17:38AM -0700, Sultan Alsawaf wrote: > > On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > > > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > > > > From: Sultan Alsawaf > > > > > > > > The following dea

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-13 Thread Sultan Alsawaf
On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > > From: Sultan Alsawaf > > > > The following deadlock exists in i915_active_wait() due to a double lock > > on ref->mutex (call chain listed in order from top to bottom): >

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-13 Thread Sultan Alsawaf
On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > > From: Sultan Alsawaf > > > > The following deadlock exists in i915_active_wait() due to a double lock > > on ref->mutex (call chain listed in order from top to bottom): >

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-11 Thread Greg KH
On Fri, Apr 10, 2020 at 07:17:38AM -0700, Sultan Alsawaf wrote: > On Fri, Apr 10, 2020 at 11:08:38AM +0200, Greg KH wrote: > > On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > > > From: Sultan Alsawaf > > > > > > The following deadlock exists in i915_active_wait() due to a double

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix ref->mutex deadlock in i915_active_wait()

2020-04-10 Thread Greg KH
On Tue, Apr 07, 2020 at 12:18:09AM -0700, Sultan Alsawaf wrote: > From: Sultan Alsawaf > > The following deadlock exists in i915_active_wait() due to a double lock > on ref->mutex (call chain listed in order from top to bottom): > i915_active_wait(); > mutex_lock_interruptible(&ref->mutex); <--