Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-11 Thread Daniel Vetter
On Fri, Oct 11, 2013 at 12:43:54PM +0100, Chris Wilson wrote: > On Fri, Oct 11, 2013 at 02:21:31PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The current pre-gen4 pipe off code might break out of the loop > > due to the timeout, but then the fail to print the warn

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-11 Thread Chris Wilson
On Fri, Oct 11, 2013 at 02:21:31PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The current pre-gen4 pipe off code might break out of the loop > due to the timeout, but then the fail to print the warning. > > Refactor the code a bit to use wait_for() to avoid the problem

[Intel-gfx] [PATCH v2] drm/i915: Fix pipe off timeout handling for pre-gen4

2013-10-11 Thread ville . syrjala
From: Ville Syrjälä The current pre-gen4 pipe off code might break out of the loop due to the timeout, but then the fail to print the warning. Refactor the code a bit to use wait_for() to avoid the problem, and that we also re-check the condition after the timeout has expired. v2: Use wait_for(