Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-24 Thread Gabriel Feceoru
On 23.02.2016 21:36, Dave Gordon wrote: On 23/02/16 14:39, Tvrtko Ursulin wrote: On 23/02/16 14:03, Chris Wilson wrote: On Tue, Feb 23, 2016 at 01:31:17PM +, Tvrtko Ursulin wrote: On 23/02/16 13:06, Gabriel Feceoru wrote: On 23.02.2016 13:05, Tvrtko Ursulin wrote: Hi, On 23/02/16

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Dave Gordon
On 23/02/16 14:39, Tvrtko Ursulin wrote: On 23/02/16 14:03, Chris Wilson wrote: On Tue, Feb 23, 2016 at 01:31:17PM +, Tvrtko Ursulin wrote: On 23/02/16 13:06, Gabriel Feceoru wrote: On 23.02.2016 13:05, Tvrtko Ursulin wrote: Hi, On 23/02/16 10:52, Gabriel Feceoru wrote: Return erro

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Tvrtko Ursulin
On 23/02/16 14:03, Chris Wilson wrote: On Tue, Feb 23, 2016 at 01:31:17PM +, Tvrtko Ursulin wrote: On 23/02/16 13:06, Gabriel Feceoru wrote: On 23.02.2016 13:05, Tvrtko Ursulin wrote: Hi, On 23/02/16 10:52, Gabriel Feceoru wrote: Return error when I915_EXEC_BSD_RING2 flag is set but

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Chris Wilson
On Tue, Feb 23, 2016 at 01:31:17PM +, Tvrtko Ursulin wrote: > > On 23/02/16 13:06, Gabriel Feceoru wrote: > > > > > > On 23.02.2016 13:05, Tvrtko Ursulin wrote: > >> > >> Hi, > >> > >> On 23/02/16 10:52, Gabriel Feceoru wrote: > >>> Return error when I915_EXEC_BSD_RING2 flag is set but BSD2

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Tvrtko Ursulin
On 23/02/16 13:06, Gabriel Feceoru wrote: > > > On 23.02.2016 13:05, Tvrtko Ursulin wrote: >> >> Hi, >> >> On 23/02/16 10:52, Gabriel Feceoru wrote: >>> Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring >>> is not available in the HW. >> >> What is the reasoning behind this? So far

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Gabriel Feceoru
On 23.02.2016 13:05, Tvrtko Ursulin wrote: Hi, On 23/02/16 10:52, Gabriel Feceoru wrote: Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring is not available in the HW. What is the reasoning behind this? So far kernel was allowing userspace to select these bits and execute on t

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Tvrtko Ursulin
Hi, On 23/02/16 10:52, Gabriel Feceoru wrote: Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring is not available in the HW. What is the reasoning behind this? So far kernel was allowing userspace to select these bits and execute on the first engine. With this patch it would st

[Intel-gfx] [PATCH v2] drm/i915: Avoid selecting unavailable BSD2 ring

2016-02-23 Thread Gabriel Feceoru
Return error when I915_EXEC_BSD_RING2 flag is set but BSD2 ring is not available in the HW. v2: Reworked Signed-off-by: Gabriel Feceoru --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/