Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

On ke, 2015-10-28 at 16:52 +0100, Patrik Jakobsson wrote: > On Tue, Oct 27, 2015 at 08:41:31PM +0200, Imre Deak wrote: > > On pe, 2015-10-23 at 11:41 +0200, Patrik Jakobsson wrote: > > > The current CSR loading code depends on the CSR program memory to be > > > cleared after boot. This is unfortuna

Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

On Tue, Oct 27, 2015 at 08:41:31PM +0200, Imre Deak wrote: > On pe, 2015-10-23 at 11:41 +0200, Patrik Jakobsson wrote: > > The current CSR loading code depends on the CSR program memory to be > > cleared after boot. This is unfortunately not true on all hardware. > > Instead make use of the FW_UNIN

Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

On pe, 2015-10-23 at 11:41 +0200, Patrik Jakobsson wrote: > The current CSR loading code depends on the CSR program memory to be > cleared after boot. This is unfortunately not true on all hardware. > Instead make use of the FW_UNINITIALIZED state in init and check for > FW_LOADED to prevent init p

Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

On Sat, Oct 24, 2015 at 11:03:05AM +0530, Animesh Manna wrote: > > > On 10/23/2015 3:11 PM, Patrik Jakobsson wrote: > >The current CSR loading code depends on the CSR program memory to be > >cleared after boot. This is unfortunately not true on all hardware. > >Instead make use of the FW_UNINITIA

Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

On 10/23/2015 3:11 PM, Patrik Jakobsson wrote: The current CSR loading code depends on the CSR program memory to be cleared after boot. This is unfortunately not true on all hardware. Instead make use of the FW_UNINITIALIZED state in init and check for FW_LOADED to prevent init path from skippi

Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

Not sure why all my CCs disappeared... Animesh, is it true that CSR_PROGRAM(0) is cleared on bxt when no program is loaded? This is not the case on skl. If it's not true on bxt either we can just skip check CSR_PROGRAM(0) altogether. Thanks Patrik On Fri, Oct 23, 2015 at 11:41:50AM +0200, Patrik

[Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

The current CSR loading code depends on the CSR program memory to be cleared after boot. This is unfortunately not true on all hardware. Instead make use of the FW_UNINITIALIZED state in init and check for FW_LOADED to prevent init path from skipping the actual programming. v2: Move initialization