Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-31 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 7274 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Daniel Stone
On 27 August 2015 at 15:34, Ville Syrjälä wrote: > On Thu, Aug 27, 2015 at 03:28:53PM +0100, Daniel Stone wrote: >> On 27 August 2015 at 15:09, Ville Syrjälä >> wrote: >> > In the kernel it should amount to >> > if (!pipe_active) >> > send_event >> >> No, thankyou. Asking for an event, h

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Ville Syrjälä
On Thu, Aug 27, 2015 at 03:28:53PM +0100, Daniel Stone wrote: > Hi, > > On 27 August 2015 at 15:09, Ville Syrjälä > wrote: > > On Thu, Aug 27, 2015 at 04:00:05PM +0200, Maarten Lankhorst wrote: > >> Op 27-08-15 om 15:50 schreef Ville Syrjälä: > >> > I don't think so. Speaking for i915, I think w

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Daniel Stone
Hi, On 27 August 2015 at 15:09, Ville Syrjälä wrote: > On Thu, Aug 27, 2015 at 04:00:05PM +0200, Maarten Lankhorst wrote: >> Op 27-08-15 om 15:50 schreef Ville Syrjälä: >> > I don't think so. Speaking for i915, I think we've just rejected legacy >> > page >> > flips entirely with the pipe is off

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Ville Syrjälä
On Thu, Aug 27, 2015 at 04:00:05PM +0200, Maarten Lankhorst wrote: > Op 27-08-15 om 15:50 schreef Ville Syrjälä: > > On Thu, Aug 27, 2015 at 03:05:38PM +0200, Maarten Lankhorst wrote: > >> Op 27-08-15 om 14:52 schreef Ville Syrjälä: > >>> On Thu, Aug 27, 2015 at 02:50:34PM +0200, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Maarten Lankhorst
Op 27-08-15 om 15:50 schreef Ville Syrjälä: > On Thu, Aug 27, 2015 at 03:05:38PM +0200, Maarten Lankhorst wrote: >> Op 27-08-15 om 14:52 schreef Ville Syrjälä: >>> On Thu, Aug 27, 2015 at 02:50:34PM +0200, Maarten Lankhorst wrote: Op 27-08-15 om 14:48 schreef Ville Syrjälä: > On Thu, Aug 2

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Ville Syrjälä
On Thu, Aug 27, 2015 at 03:05:38PM +0200, Maarten Lankhorst wrote: > Op 27-08-15 om 14:52 schreef Ville Syrjälä: > > On Thu, Aug 27, 2015 at 02:50:34PM +0200, Maarten Lankhorst wrote: > >> Op 27-08-15 om 14:48 schreef Ville Syrjälä: > >>> On Thu, Aug 27, 2015 at 02:43:35PM +0200, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Daniel Stone
Hi, On 27 August 2015 at 13:43, Maarten Lankhorst wrote: > Op 27-08-15 om 14:19 schreef Daniel Stone: >> On 4 August 2015 at 12:34, Maarten Lankhorst >> wrote: >> An early test precludes TEST_ONLY | PAGE_FLIP_EVENT, so you don't need >> to mention this in the commit message; in this case, the ma

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Maarten Lankhorst
Op 27-08-15 om 14:52 schreef Ville Syrjälä: > On Thu, Aug 27, 2015 at 02:50:34PM +0200, Maarten Lankhorst wrote: >> Op 27-08-15 om 14:48 schreef Ville Syrjälä: >>> On Thu, Aug 27, 2015 at 02:43:35PM +0200, Maarten Lankhorst wrote: Op 27-08-15 om 14:19 schreef Daniel Stone: > Hi, >

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Ville Syrjälä
On Thu, Aug 27, 2015 at 02:50:34PM +0200, Maarten Lankhorst wrote: > Op 27-08-15 om 14:48 schreef Ville Syrjälä: > > On Thu, Aug 27, 2015 at 02:43:35PM +0200, Maarten Lankhorst wrote: > >> Op 27-08-15 om 14:19 schreef Daniel Stone: > >>> Hi, > >>> > >>> On 4 August 2015 at 12:34, Maarten Lankhorst

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Maarten Lankhorst
Op 27-08-15 om 14:48 schreef Ville Syrjälä: > On Thu, Aug 27, 2015 at 02:43:35PM +0200, Maarten Lankhorst wrote: >> Op 27-08-15 om 14:19 schreef Daniel Stone: >>> Hi, >>> >>> On 4 August 2015 at 12:34, Maarten Lankhorst >>> wrote: Commit ec9f932ed41622d120de52a5b525e4d77b9ef17e "drm/atom

Re: [Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Ville Syrjälä
On Thu, Aug 27, 2015 at 02:43:35PM +0200, Maarten Lankhorst wrote: > Op 27-08-15 om 14:19 schreef Daniel Stone: > > Hi, > > > > On 4 August 2015 at 12:34, Maarten Lankhorst > > wrote: > >> Commit ec9f932ed41622d120de52a5b525e4d77b9ef17e > >> "drm/atomic: Cleanup on error properly in the atomic ioc

[Intel-gfx] [PATCH v2] drm/atomic: Fix bookkeeping with TEST_ONLY, v2.

2015-08-27 Thread Maarten Lankhorst
Op 27-08-15 om 14:19 schreef Daniel Stone: > Hi, > > On 4 August 2015 at 12:34, Maarten Lankhorst > wrote: >> Commit ec9f932ed41622d120de52a5b525e4d77b9ef17e >> "drm/atomic: Cleanup on error properly in the atomic ioctl." >> cleaned up some error paths, but didn't fix the TEST_ONLY path. >> In the