Re: [Intel-gfx] [PATCH v2] drivers: i915: Default max backlight brightness value

2011-11-02 Thread Simon Que
On Tue, Nov 1, 2011 at 7:54 PM, Matthew Garrett wrote: > Again, adding arbitrary constants without any explanation for why you're > making this the default really isn't acceptable. We have no way to > determine whether fixing one machine is worth making things worse for > another. The default is

Re: [Intel-gfx] [PATCH v2] drivers: i915: Default max backlight brightness value

2011-11-01 Thread Matthew Garrett
Again, adding arbitrary constants without any explanation for why you're making this the default really isn't acceptable. We have no way to determine whether fixing one machine is worth making things worse for another. -- Matthew Garrett | mj...@srcf.ucam.org __

[Intel-gfx] [PATCH v2] drivers: i915: Default max backlight brightness value

2011-11-01 Thread Simon Que
Use 0x1000 as the default backlight PWM max value and period. This is passed in as a module parameter to i915_drv and is used to program the PWM registers. It can be set to other values based on the needs of each system. Signed-off-by: Simon Que --- drivers/gpu/drm/i915/i915_drv.c|3 ++