Re: [Intel-gfx] [PATCH v13 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-20 Thread Lisovskiy, Stanislav
On Fri, 2020-01-17 at 11:06 -0800, Matt Roper wrote: > On Fri, Jan 17, 2020 at 11:50:25AM +0200, Stanislav Lisovskiy wrote: > > Start manipulating DBuf slices as a mask, > > but not as a total number, as current approach > > doesn't give us full control on all combinations > > of slices, which we m

Re: [Intel-gfx] [PATCH v13 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-17 Thread Matt Roper
On Fri, Jan 17, 2020 at 11:50:25AM +0200, Stanislav Lisovskiy wrote: > Start manipulating DBuf slices as a mask, > but not as a total number, as current approach > doesn't give us full control on all combinations > of slices, which we might need(like enabling S2 > only can't enabled by setting enab

Re: [Intel-gfx] [PATCH v13 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-17 Thread Ville Syrjälä
On Fri, Jan 17, 2020 at 11:50:25AM +0200, Stanislav Lisovskiy wrote: > Start manipulating DBuf slices as a mask, > but not as a total number, as current approach > doesn't give us full control on all combinations > of slices, which we might need(like enabling S2 > only can't enabled by setting enab

[Intel-gfx] [PATCH v13 4/5] drm/i915: Manipulate DBuf slices properly

2020-01-17 Thread Stanislav Lisovskiy
Start manipulating DBuf slices as a mask, but not as a total number, as current approach doesn't give us full control on all combinations of slices, which we might need(like enabling S2 only can't enabled by setting enabled_slices=1). Removed wrong code from intel_get_ddb_size as it doesn't match