Re: [Intel-gfx] [PATCH i-g-t v3 2/4] tests/ chamelium: Remove the frame dump tests

2017-07-06 Thread Paul Kocialkowski
On Wed, 2017-07-05 at 16:53 -0400, Lyude Paul wrote: > NAK. You're right that these don't actually give us any advantage over > just using CRCs and are just slower, however I left these tests in > here > moreso just so we had something to actually test the frame dumping > functions so that we could

Re: [Intel-gfx] [PATCH i-g-t v3 2/4] tests/ chamelium: Remove the frame dump tests

2017-07-06 Thread Martin Peres
On 05/07/17 23:53, Lyude Paul wrote: NAK. You're right that these don't actually give us any advantage over just using CRCs and are just slower, however I left these tests in here moreso just so we had something to actually test the frame dumping functions so that we could avoid regressing them b

Re: [Intel-gfx] [PATCH i-g-t v3 2/4] tests/ chamelium: Remove the frame dump tests

2017-07-05 Thread Lyude Paul
NAK. You're right that these don't actually give us any advantage over just using CRCs and are just slower, however I left these tests in here moreso just so we had something to actually test the frame dumping functions so that we could avoid regressing them by accident since we're the only users o

[Intel-gfx] [PATCH i-g-t v3 2/4] tests/ chamelium: Remove the frame dump tests

2017-07-05 Thread Paul Kocialkowski
The frame dump tests provide no additional functionality over CRC tests and are considerably slower. Thus, these tests should be considered as poorer duplicates and removed. Signed-off-by: Paul Kocialkowski --- tests/chamelium.c | 53 - 1 file