Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-06-05 Thread Petri Latvala
On 6/5/19 12:38 AM, Lucas De Marchi wrote: On Fri, May 31, 2019 at 07:55:45AM -0700, Lucas De Marchi wrote: On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote: On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote: We want to check if the long option conflicts with one fr

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-06-04 Thread Lucas De Marchi
On Fri, May 31, 2019 at 07:55:45AM -0700, Lucas De Marchi wrote: On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote: On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote: We want to check if the long option conflicts with one from the core. The check for conflicting short

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-05-31 Thread Lucas De Marchi
On Fri, May 31, 2019 at 12:59:35PM +0300, Petri Latvala wrote: On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote: We want to check if the long option conflicts with one from the core. The check for conflicting short option already exists just above. No, this one is checking that

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-05-31 Thread Petri Latvala
On Wed, May 29, 2019 at 04:27:33PM -0700, Lucas De Marchi wrote: > We want to check if the long option conflicts with one from the core. > The check for conflicting short option already exists just above. No, this one is checking that the val (the 0) doesn't conflict. -- Petri Latvala > > Si

[Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-05-29 Thread Lucas De Marchi
We want to check if the long option conflicts with one from the core. The check for conflicting short option already exists just above. Signed-off-by: Lucas De Marchi --- lib/tests/igt_conflicting_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tests/igt_conflictin