Re: [Intel-gfx] [PATCH i-g-t 05/43] igt_kms: Add support for setting plane rotation

2014-07-11 Thread Damien Lespiau
On Fri, Jul 11, 2014 at 08:37:42AM +0200, Daniel Vetter wrote: > On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote: > > Signed-off-by: Damien Lespiau > > --- > > lib/igt_kms.c | 54 ++ > > lib/igt_kms.h | 11 +++ > > 2 files

Re: [Intel-gfx] [PATCH i-g-t 05/43] igt_kms: Add support for setting plane rotation

2014-07-11 Thread Daniel Vetter
On Fri, Jul 11, 2014 at 07:42:56AM +0100, Chris Wilson wrote: > On Fri, Jul 11, 2014 at 08:40:29AM +0200, Daniel Vetter wrote: > > On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote: > > > +typedef enum { > > > + /* this maps to the kernel API */ > > > + IGT_ROTATION_0 = 1 << 0, > > >

Re: [Intel-gfx] [PATCH i-g-t 05/43] igt_kms: Add support for setting plane rotation

2014-07-10 Thread Chris Wilson
On Fri, Jul 11, 2014 at 08:40:29AM +0200, Daniel Vetter wrote: > On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote: > > +typedef enum { > > + /* this maps to the kernel API */ > > + IGT_ROTATION_0 = 1 << 0, > > + IGT_ROTATION_90 = 1 << 1, > > + IGT_ROTATION_180 = 1 << 2, > >

Re: [Intel-gfx] [PATCH i-g-t 05/43] igt_kms: Add support for setting plane rotation

2014-07-10 Thread Daniel Vetter
On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote: > +typedef enum { > + /* this maps to the kernel API */ > + IGT_ROTATION_0 = 1 << 0, > + IGT_ROTATION_90 = 1 << 1, > + IGT_ROTATION_180 = 1 << 2, > + IGT_ROTATION_270 = 1 << 3, > +} igt_rotation_t; Should we als

Re: [Intel-gfx] [PATCH i-g-t 05/43] igt_kms: Add support for setting plane rotation

2014-07-10 Thread Daniel Vetter
On Thu, Jul 10, 2014 at 07:00:06PM +0100, Damien Lespiau wrote: > Signed-off-by: Damien Lespiau > --- > lib/igt_kms.c | 54 ++ > lib/igt_kms.h | 11 +++ > 2 files changed, 65 insertions(+) > > diff --git a/lib/igt_kms.c b/lib/igt_kms.c

[Intel-gfx] [PATCH i-g-t 05/43] igt_kms: Add support for setting plane rotation

2014-07-10 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- lib/igt_kms.c | 54 ++ lib/igt_kms.h | 11 +++ 2 files changed, 65 insertions(+) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 87f5109..69f9977 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -537,