Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-12 Thread Arkadiusz Hiler
On Thu, Sep 07, 2017 at 02:15:14PM +0200, Katarzyna Dec wrote: > Added comments in tricky places for better feature understanding. > Added IGT_TEST_DESCRIPTION and short description for non-obvious > subtests. > Changed name of 'magic' checkit() function to something meaningfull. > Changed junk str

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-12 Thread Petri Latvala
On Thu, Sep 07, 2017 at 02:15:14PM +0200, Katarzyna Dec wrote: > Added comments in tricky places for better feature understanding. > Added IGT_TEST_DESCRIPTION and short description for non-obvious > subtests. > Changed name of 'magic' checkit() function to something meaningfull. > Changed junk str

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-12 Thread Michał Winiarski
On Fri, Sep 08, 2017 at 09:48:17AM -0700, Belgaumkar, Vinay wrote: [SNIP] > > > > > > > > + /* Checks if we achieve boost using gem_wait */ > > > > > > We should mention this is doing gem_wait on a spinning batch, hence the > > > boost. > > I think that additional information is not neede

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-08 Thread Belgaumkar, Vinay
On 9/8/2017 12:19 AM, Katarzyna Dec wrote: On Thu, Sep 07, 2017 at 11:28:38AM -0700, Belgaumkar, Vinay wrote: On 9/7/2017 5:15 AM, Katarzyna Dec wrote: Added comments in tricky places for better feature understanding. Added IGT_TEST_DESCRIPTION and short description for non-obvious subtests

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-08 Thread Szwichtenberg, Radoslaw
On Thu, 2017-09-07 at 11:28 -0700, Belgaumkar, Vinay wrote: > > On 9/7/2017 5:15 AM, Katarzyna Dec wrote: > > Added comments in tricky places for better feature understanding. > > Added IGT_TEST_DESCRIPTION and short description for non-obvious > > subtests. > > Changed name of 'magic' checkit() f

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-08 Thread Katarzyna Dec
On Thu, Sep 07, 2017 at 11:28:38AM -0700, Belgaumkar, Vinay wrote: > > > On 9/7/2017 5:15 AM, Katarzyna Dec wrote: > > Added comments in tricky places for better feature understanding. > > Added IGT_TEST_DESCRIPTION and short description for non-obvious > > subtests. > > Changed name of 'magic' c

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-07 Thread Belgaumkar, Vinay
On 9/7/2017 5:15 AM, Katarzyna Dec wrote: Added comments in tricky places for better feature understanding. Added IGT_TEST_DESCRIPTION and short description for non-obvious subtests. Changed name of 'magic' checkit() function to something meaningfull. Changed junk struct and stuff array names.

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-07 Thread Arkadiusz Hiler
On Thu, Sep 07, 2017 at 02:15:14PM +0200, Katarzyna Dec wrote: > Added comments in tricky places for better feature understanding. > Added IGT_TEST_DESCRIPTION and short description for non-obvious > subtests. > Changed name of 'magic' checkit() function to something meaningfull. > Changed junk str

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-07 Thread Szwichtenberg, Radoslaw
On Thu, 2017-09-07 at 14:15 +0200, Katarzyna Dec wrote: > Added comments in tricky places for better feature understanding. > Added IGT_TEST_DESCRIPTION and short description for non-obvious > subtests. > Changed name of 'magic' checkit() function to something meaningfull. > Changed junk struct and

[Intel-gfx] [PATCH i-g-t] pm_rps: [RFC] RPS tests documentation update

2017-09-07 Thread Katarzyna Dec
Added comments in tricky places for better feature understanding. Added IGT_TEST_DESCRIPTION and short description for non-obvious subtests. Changed name of 'magic' checkit() function to something meaningfull. Changed junk struct and stuff array names. Made some minor coding style changes. Cc: Vin