Hi Fengguang,
> -Original Message-
> From: Wu, Fengguang
> Sent: Wednesday, August 15, 2012 4:01 PM
> To: Wang, Xingchao
> Cc: intel-gfx@lists.freedesktop.org; dan...@ffwll.ch; Fu, Michael;
> zhen...@linux.intel.com
> Subject: Re: [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump
> s
Xingchao,
Have you tested the patch in haswell as well as in older hardwares?
In general it would be better if you have run this tool for some time
on several hardwares -- that's the best way to smooth out possible bugs.
> +/*Haswell registers*/
Please fix the style to (ditto for lots of other c
Add Haswell audio registers definition and dump support.
Signed-off-by: Wang Xingchao
---
tools/intel_audio_dump.c | 582 ++
1 file changed, 582 insertions(+)
diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c
index 8a0f6ee..5ee9372 100