Re: [Intel-gfx] [PATCH 8/8] drm/i915: fix hpd interrupt register locking

2013-06-27 Thread Daniel Vetter
On Thu, Jun 27, 2013 at 11:41:25AM -0300, Paulo Zanoni wrote: > 2013/6/27 Daniel Vetter : > > Our interrupt handler (in hardird context) could race with the timer > > s/hardird/hardirq/ > > > (in softirq context), hence we need to hold the spinlock around the > > call to ->hdp_irq_setup in intel_

Re: [Intel-gfx] [PATCH 8/8] drm/i915: fix hpd interrupt register locking

2013-06-27 Thread Paulo Zanoni
2013/6/27 Daniel Vetter : > Our interrupt handler (in hardird context) could race with the timer s/hardird/hardirq/ > (in softirq context), hence we need to hold the spinlock around the > call to ->hdp_irq_setup in intel_hpd_irq_handler, too. > > But as an optimization (and more so to clarify thi

[Intel-gfx] [PATCH 8/8] drm/i915: fix hpd interrupt register locking

2013-06-27 Thread Daniel Vetter
Our interrupt handler (in hardird context) could race with the timer (in softirq context), hence we need to hold the spinlock around the call to ->hdp_irq_setup in intel_hpd_irq_handler, too. But as an optimization (and more so to clarify things) we don't need to do the irqsave/restore dance in th