Re: [Intel-gfx] [PATCH 8/8] drm/i915: Wait on external rendering for GEM objects

2016-07-20 Thread Joonas Lahtinen
On ti, 2016-07-19 at 15:27 +0100, Chris Wilson wrote: > On Tue, Jul 19, 2016 at 05:12:22PM +0300, Joonas Lahtinen wrote: > > > > On ti, 2016-07-19 at 11:51 +0100, Chris Wilson wrote: > > > > > > + resv = i915_gem_object_get_dmabuf_resv(obj); > > > + if (resv) { > > > + long err; > > We al

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Wait on external rendering for GEM objects

2016-07-19 Thread Chris Wilson
On Tue, Jul 19, 2016 at 05:12:22PM +0300, Joonas Lahtinen wrote: > On ti, 2016-07-19 at 11:51 +0100, Chris Wilson wrote: > > + resv = i915_gem_object_get_dmabuf_resv(obj); > > + if (resv) { > > + long err; > > We already have ret in the function scope. ret is int, we need a long. At

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Wait on external rendering for GEM objects

2016-07-19 Thread Joonas Lahtinen
On ti, 2016-07-19 at 11:51 +0100, Chris Wilson wrote: > When transitioning to the GTT or CPU domain we wait on all rendering > from i915 to complete (with the optimisation of allowing concurrent read > access by both the GPU and client). We don't yet ensure all rendering > from third parties (track

[Intel-gfx] [PATCH 8/8] drm/i915: Wait on external rendering for GEM objects

2016-07-19 Thread Chris Wilson
When transitioning to the GTT or CPU domain we wait on all rendering from i915 to complete (with the optimisation of allowing concurrent read access by both the GPU and client). We don't yet ensure all rendering from third parties (tracked by implicit fences on the dma-buf) is complete. Since impli