Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-13 Thread Daniel Vetter
On Fri, Oct 09, 2015 at 01:06:24PM +0100, Tomas Elf wrote: > On 09/10/2015 11:44, Chris Wilson wrote: > >On Fri, Oct 09, 2015 at 11:30:34AM +0100, Tomas Elf wrote: > >>On 09/10/2015 08:46, Chris Wilson wrote: > >>>On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: > Avoid NULL pointer e

Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-09 Thread Tomas Elf
On 09/10/2015 11:44, Chris Wilson wrote: On Fri, Oct 09, 2015 at 11:30:34AM +0100, Tomas Elf wrote: On 09/10/2015 08:46, Chris Wilson wrote: On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: Avoid NULL pointer exceptions in the display driver for certain critical cases when unpin_work

Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-09 Thread Tomas Elf
On 09/10/2015 09:39, Daniel Vetter wrote: On Fri, Oct 09, 2015 at 08:46:31AM +0100, Chris Wilson wrote: On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: Avoid NULL pointer exceptions in the display driver for certain critical cases when unpin_work has turned out to be NULL. Nope, th

Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 11:30:34AM +0100, Tomas Elf wrote: > On 09/10/2015 08:46, Chris Wilson wrote: > >On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: > >>Avoid NULL pointer exceptions in the display driver for certain critical > >>cases > >>when unpin_work has turned out to be NULL.

Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-09 Thread Tomas Elf
On 09/10/2015 08:46, Chris Wilson wrote: On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: Avoid NULL pointer exceptions in the display driver for certain critical cases when unpin_work has turned out to be NULL. Nope, the machine reached a point where it cannot possibly reach, we wan

Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-09 Thread Daniel Vetter
On Fri, Oct 09, 2015 at 08:46:31AM +0100, Chris Wilson wrote: > On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: > > Avoid NULL pointer exceptions in the display driver for certain critical > > cases > > when unpin_work has turned out to be NULL. > > Nope, the machine reached a point wh

Re: [Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-09 Thread Chris Wilson
On Thu, Oct 08, 2015 at 07:31:40PM +0100, Tomas Elf wrote: > Avoid NULL pointer exceptions in the display driver for certain critical cases > when unpin_work has turned out to be NULL. Nope, the machine reached a point where it cannot possibly reach, we want the OOPS. -Chris -- Chris Wilson, Int

[Intel-gfx] [PATCH 8/8] drm/i915: NULL check of unpin_work

2015-10-08 Thread Tomas Elf
Avoid NULL pointer exceptions in the display driver for certain critical cases when unpin_work has turned out to be NULL. Signed-off-by: Tomas Elf --- drivers/gpu/drm/i915/intel_display.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu