Re: [Intel-gfx] [PATCH 7/9] drm/i915: don't alloc/free fbc_work at every update

2014-12-26 Thread Paulo Zanoni
2014-12-25 8:33 GMT-02:00 Chris Wilson : > On Tue, Dec 23, 2014 at 10:35:43AM -0200, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> Because there's no need for it. Just use a static structure with a >> bool field to tell if it's in use or not. The big advantage here is >> not saving kzalloc/kfree

Re: [Intel-gfx] [PATCH 7/9] drm/i915: don't alloc/free fbc_work at every update

2014-12-25 Thread Chris Wilson
On Tue, Dec 23, 2014 at 10:35:43AM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni > > Because there's no need for it. Just use a static structure with a > bool field to tell if it's in use or not. The big advantage here is > not saving kzalloc/kfree calls, it's cutting the ugly "failed to > allo

[Intel-gfx] [PATCH 7/9] drm/i915: don't alloc/free fbc_work at every update

2014-12-23 Thread Paulo Zanoni
From: Paulo Zanoni Because there's no need for it. Just use a static structure with a bool field to tell if it's in use or not. The big advantage here is not saving kzalloc/kfree calls, it's cutting the ugly "failed to allocate FBC work structure" code path: in this path we call enable_fbc() dire