Re: [Intel-gfx] [PATCH 7/7] drm/i915: add i9xx pfit pipe asserts

2013-04-15 Thread Daniel Vetter
On Fri, Apr 12, 2013 at 03:02:32PM +0100, Chris Wilson wrote: > On Thu, Apr 11, 2013 at 04:29:10PM +0200, Daniel Vetter wrote: > > We can only enable the pfit if the pipe. Ensure that this is obied > > with a neat assert. > > > > Also check whether the pfit is off before enabling it - if not we've

Re: [Intel-gfx] [PATCH 7/7] drm/i915: add i9xx pfit pipe asserts

2013-04-12 Thread Chris Wilson
On Thu, Apr 11, 2013 at 04:29:10PM +0200, Daniel Vetter wrote: > We can only enable the pfit if the pipe. Ensure that this is obied > with a neat assert. > > Also check whether the pfit is off before enabling it - if not we've > lost track of things somewhere since the pfit is only ever used by th

Re: [Intel-gfx] [PATCH 7/7] drm/i915: add i9xx pfit pipe asserts

2013-04-11 Thread Jani Nikula
On Thu, 11 Apr 2013, Ville Syrjälä wrote: > On Thu, Apr 11, 2013 at 04:29:10PM +0200, Daniel Vetter wrote: >> We can only enable the pfit if the pipe. Ensure that this is obied ^ "obeyed" or something? Jani. >

Re: [Intel-gfx] [PATCH 7/7] drm/i915: add i9xx pfit pipe asserts

2013-04-11 Thread Daniel Vetter
On Thu, Apr 11, 2013 at 6:37 PM, Ville Syrjälä wrote: > On Thu, Apr 11, 2013 at 04:29:10PM +0200, Daniel Vetter wrote: >> We can only enable the pfit if the pipe. Ensure that this is obied > ^ > > "is disabled" or something? Indeed. -- Daniel Vetter Softwa

Re: [Intel-gfx] [PATCH 7/7] drm/i915: add i9xx pfit pipe asserts

2013-04-11 Thread Ville Syrjälä
On Thu, Apr 11, 2013 at 04:29:10PM +0200, Daniel Vetter wrote: > We can only enable the pfit if the pipe. Ensure that this is obied ^ "is disabled" or something? > with a neat assert. > > Also check whether the pfit is off before enabling it - if not we'v

[Intel-gfx] [PATCH 7/7] drm/i915: add i9xx pfit pipe asserts

2013-04-11 Thread Daniel Vetter
We can only enable the pfit if the pipe. Ensure that this is obied with a neat assert. Also check whether the pfit is off before enabling it - if not we've lost track of things somewhere since the pfit is only ever used by the lvds output. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i