Re: [Intel-gfx] [PATCH 7/7] drm/i915: Mark gen specific conditions 'likely'

2013-10-05 Thread Daniel Vetter
On Fri, Oct 04, 2013 at 09:22:55PM -0700, Ben Widawsky wrote: > Now that MMIO has been split up into gen specific functions it is > obvious when HAS_FPGA_DBG_UNCLAIMED, HAS_FORCE_WAKE are needed. > > I'm a bit on the fence whether or not to even have the checks at all. > For now I am leaving them

[Intel-gfx] [PATCH 7/7] drm/i915: Mark gen specific conditions 'likely'

2013-10-04 Thread Ben Widawsky
Now that MMIO has been split up into gen specific functions it is obvious when HAS_FPGA_DBG_UNCLAIMED, HAS_FORCE_WAKE are needed. I'm a bit on the fence whether or not to even have the checks at all. For now I am leaving them there because I think they are valuable for debug, and early silicon bri