Re: [Intel-gfx] [PATCH 6/6 v2] drm/i915: Make GSM void

2012-12-20 Thread Daniel Vetter
On Wed, Dec 19, 2012 at 11:20:15AM -0800, Ben Widawsky wrote: > On Wed, Dec 19, 2012 at 01:45:23PM +0200, Ville Syrjälä wrote: > > On Tue, Dec 18, 2012 at 10:31:27AM -0800, Ben Widawsky wrote: > > > The iomapping of the register region has historically been a uint32_t > > > for the obvious reason t

Re: [Intel-gfx] [PATCH 6/6 v2] drm/i915: Make GSM void

2012-12-19 Thread Ben Widawsky
On Wed, Dec 19, 2012 at 01:45:23PM +0200, Ville Syrjälä wrote: > On Tue, Dec 18, 2012 at 10:31:27AM -0800, Ben Widawsky wrote: > > The iomapping of the register region has historically been a uint32_t > > for the obvious reason that our PTE size was always 4b. In the future > > however, we cannot m

Re: [Intel-gfx] [PATCH 6/6 v2] drm/i915: Make GSM void

2012-12-19 Thread Ville Syrjälä
On Tue, Dec 18, 2012 at 10:31:27AM -0800, Ben Widawsky wrote: > The iomapping of the register region has historically been a uint32_t > for the obvious reason that our PTE size was always 4b. In the future > however, we cannot make this assumption. > > By making the type void, it makes the upcomin

[Intel-gfx] [PATCH 6/6 v2] drm/i915: Make GSM void

2012-12-18 Thread Ben Widawsky
The iomapping of the register region has historically been a uint32_t for the obvious reason that our PTE size was always 4b. In the future however, we cannot make this assumption. By making the type void, it makes the upcoming pointer math we will do much easier, and hopefully gives the compiler