Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-11 Thread Tvrtko Ursulin
On 11/12/15 05:16, Ankitprasad Sharma wrote: On Thu, 2015-12-10 at 14:15 +, Tvrtko Ursulin wrote: On 10/12/15 13:17, Ankitprasad Sharma wrote: On Thu, 2015-12-10 at 09:43 +, Tvrtko Ursulin wrote: Hi, Two more comments below: On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote:

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Ankitprasad Sharma
On Thu, 2015-12-10 at 18:00 +, Dave Gordon wrote: > On 10/12/15 14:15, Tvrtko Ursulin wrote: > > > > On 10/12/15 13:17, Ankitprasad Sharma wrote: > >> On Thu, 2015-12-10 at 09:43 +, Tvrtko Ursulin wrote: > >>> Hi, > >>> > >>> Two more comments below: > >>> > >>> On 09/12/15 12:46, ankitpras

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Ankitprasad Sharma
On Thu, 2015-12-10 at 14:15 +, Tvrtko Ursulin wrote: > On 10/12/15 13:17, Ankitprasad Sharma wrote: > > On Thu, 2015-12-10 at 09:43 +, Tvrtko Ursulin wrote: > >> Hi, > >> > >> Two more comments below: > >> > >> On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: > >>> From: Chris Wilso

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Dave Gordon
On 10/12/15 14:15, Tvrtko Ursulin wrote: On 10/12/15 13:17, Ankitprasad Sharma wrote: On Thu, 2015-12-10 at 09:43 +, Tvrtko Ursulin wrote: Hi, Two more comments below: On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: From: Chris Wilson Ville reminded us that stolen memory is n

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Tvrtko Ursulin
On 10/12/15 13:17, Ankitprasad Sharma wrote: On Thu, 2015-12-10 at 09:43 +, Tvrtko Ursulin wrote: Hi, Two more comments below: On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a res

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Ankitprasad Sharma
On Thu, 2015-12-10 at 09:43 +, Tvrtko Ursulin wrote: > Hi, > > Two more comments below: > > On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: > > From: Chris Wilson > > > > Ville reminded us that stolen memory is not preserved across > > hibernation, and a result of this was that cont

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Ankitprasad Sharma
On Wed, 2015-12-09 at 17:25 +, Tvrtko Ursulin wrote: > Hi, > > On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: > > From: Chris Wilson > > > > Ville reminded us that stolen memory is not preserved across > > hibernation, and a result of this was that context objects now being > > allo

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-10 Thread Tvrtko Ursulin
Hi, Two more comments below: On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promp

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-09 Thread Dave Gordon
On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume.

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-09 Thread Ville Syrjälä
On Wed, Dec 09, 2015 at 05:25:19PM +, Tvrtko Ursulin wrote: > > Hi, > > On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: > > From: Chris Wilson > > > > Ville reminded us that stolen memory is not preserved across > > hibernation, and a result of this was that context objects now bein

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-09 Thread Tvrtko Ursulin
Hi, On 09/12/15 12:46, ankitprasad.r.sha...@intel.com wrote: From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on re

[Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-09 Thread ankitprasad . r . sharma
From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume. We want to utilise stolen for as much as possible (nothing

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-12-02 Thread Ville Syrjälä
On Wed, Nov 11, 2015 at 04:06:13PM +0530, ankitprasad.r.sha...@intel.com wrote: > From: Chris Wilson > > Ville reminded us that stolen memory is not preserved across > hibernation, and a result of this was that context objects now being > allocated from stolen were being corrupted on S4 and promp

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-11-11 Thread Chris Wilson
On Wed, Nov 11, 2015 at 04:06:13PM +0530, ankitprasad.r.sha...@intel.com wrote: > +swap_pages: > + stolen_pages = obj->pages; > + obj->pages = NULL; > + > + obj->base.filp = file; > + obj->base.read_domains = I915_GEM_DOMAIN_CPU; > + obj->base.write_domain = I915_GEM_DOMAIN_CPU;

[Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-11-11 Thread ankitprasad . r . sharma
From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume. We want to utilise stolen for as much as possible (nothing

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-10-28 Thread Ankitprasad Sharma
On Thu, 2015-10-08 at 12:02 +0100, Chris Wilson wrote: > On Thu, Oct 08, 2015 at 11:54:29AM +0530, ankitprasad.r.sha...@intel.com > wrote: > > + /* stolen objects are already pinned to prevent shrinkage */ > > + memset(&node, 0, sizeof(node)); > > + ret = drm_mm_insert_node_in_range_generic(

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-10-12 Thread Ankitprasad Sharma
On Thu, 2015-10-08 at 12:02 +0100, Chris Wilson wrote: > On Thu, Oct 08, 2015 at 11:54:29AM +0530, ankitprasad.r.sha...@intel.com > wrote: > > + /* stolen objects are already pinned to prevent shrinkage */ > > + memset(&node, 0, sizeof(node)); > > + ret = drm_mm_insert_node_in_range_generic(

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-10-08 Thread Chris Wilson
On Thu, Oct 08, 2015 at 11:54:29AM +0530, ankitprasad.r.sha...@intel.com wrote: > + /* stolen objects are already pinned to prevent shrinkage */ > + memset(&node, 0, sizeof(node)); > + ret = drm_mm_insert_node_in_range_generic(&i915->gtt.base.mm, > +

[Intel-gfx] [PATCH 6/6] drm/i915: Migrate stolen objects before hibernation

2015-10-07 Thread ankitprasad . r . sharma
From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume. We want to utilise stolen for as much as possible (nothing