Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-03 Thread Summers, Stuart
On Fri, 2019-05-03 at 10:05 +0100, Lionel Landwerlin wrote: > Acked-by: Lionel Landwerlin Thanks for the Ack! -Stuart smime.p7s Description: S/MIME cryptographic signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freed

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-03 Thread Lionel Landwerlin
On 02/05/2019 15:47, Summers, Stuart wrote: On Wed, 2019-05-01 at 15:04 -0700, Daniele Ceraolo Spurio wrote: On 5/1/19 8:34 AM, Stuart Summers wrote: Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-02 Thread Summers, Stuart
On Wed, 2019-05-01 at 15:04 -0700, Daniele Ceraolo Spurio wrote: > > On 5/1/19 8:34 AM, Stuart Summers wrote: > > Currently, the subslice_mask runtime parameter is stored as an > > array of subslices per slice. Expand the subslice mask array to > > better match what is presented to userspace throu

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-01 Thread Daniele Ceraolo Spurio
On 5/1/19 8:34 AM, Stuart Summers wrote: Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calcu

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-01 Thread Summers, Stuart
On Wed, 2019-05-01 at 19:29 +0100, Tvrtko Ursulin wrote: > On 01/05/2019 19:22, Tvrtko Ursulin wrote: > > [snip] > > > > +#define SS_STR_MAX_SIZE (GEN_MAX_SUBSLICE_STRIDE * 2) > > > + > > > +static u8 * > > > +subslice_per_slice_str(u8 *buf, const struct sseu_dev_info > > > *sseu, u8 > > > slice

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-01 Thread Tvrtko Ursulin
On 01/05/2019 19:22, Tvrtko Ursulin wrote: [snip] +#define SS_STR_MAX_SIZE (GEN_MAX_SUBSLICE_STRIDE * 2) + +static u8 * +subslice_per_slice_str(u8 *buf, const struct sseu_dev_info *sseu, u8 slice) +{ +    int i; +    u8 ss_offset = slice * sseu->ss_stride; + +    GEM_BUG_ON(slice >= sseu->ma

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-01 Thread Tvrtko Ursulin
Just one drive by below... On 01/05/2019 16:34, Stuart Summers wrote: Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index

[Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-05-01 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice i

[Intel-gfx] [PATCH 6/6] drm/i915: Expand subslice mask

2019-04-30 Thread Stuart Summers
Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calculated: slice * subslice stride + subslice i