Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-07-01 Thread Ben Widawsky
On Sun, Jun 30, 2013 at 01:36:39PM +0200, Daniel Vetter wrote: > On Sun, Jun 30, 2013 at 1:31 PM, Chris Wilson > wrote: > > I respectfully disagree. The semantics of the pin ioctl remain useful > > even with the ggtt/ppgtt split, and I think barring its use forever more > > is unwise. Not that pi

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-30 Thread Daniel Vetter
On Sun, Jun 30, 2013 at 1:31 PM, Chris Wilson wrote: > I respectfully disagree. The semantics of the pin ioctl remain useful > even with the ggtt/ppgtt split, and I think barring its use forever more > is unwise. Not that pinning is a good solution, just in some cases it > may be the only solution

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-30 Thread Chris Wilson
On Sun, Jun 30, 2013 at 01:06:47PM +0200, Daniel Vetter wrote: > On Sat, Jun 29, 2013 at 11:56:53PM -0700, Ben Widawsky wrote: > > On Sat, Jun 29, 2013 at 04:34:07PM +0200, Daniel Vetter wrote: > > > On Sat, Jun 29, 2013 at 8:44 AM, Chris Wilson > > > wrote: > > > > On Fri, Jun 28, 2013 at 10:43:

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-30 Thread Daniel Vetter
On Sat, Jun 29, 2013 at 11:56:53PM -0700, Ben Widawsky wrote: > On Sat, Jun 29, 2013 at 04:34:07PM +0200, Daniel Vetter wrote: > > On Sat, Jun 29, 2013 at 8:44 AM, Chris Wilson > > wrote: > > > On Fri, Jun 28, 2013 at 10:43:30PM -0700, Ben Widawsky wrote: > > >> On Fri, Jun 28, 2013 at 09:55:27AM

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-29 Thread Ben Widawsky
On Sat, Jun 29, 2013 at 04:34:07PM +0200, Daniel Vetter wrote: > On Sat, Jun 29, 2013 at 8:44 AM, Chris Wilson > wrote: > > On Fri, Jun 28, 2013 at 10:43:30PM -0700, Ben Widawsky wrote: > >> On Fri, Jun 28, 2013 at 09:55:27AM +0100, Chris Wilson wrote: > >> > On Thu, Jun 27, 2013 at 04:30:58PM -0

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-29 Thread Daniel Vetter
On Sat, Jun 29, 2013 at 8:44 AM, Chris Wilson wrote: > On Fri, Jun 28, 2013 at 10:43:30PM -0700, Ben Widawsky wrote: >> On Fri, Jun 28, 2013 at 09:55:27AM +0100, Chris Wilson wrote: >> > On Thu, Jun 27, 2013 at 04:30:58PM -0700, Ben Widawsky wrote: >> > > Pin doesn't fit with PPGTT since the inter

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-28 Thread Chris Wilson
On Fri, Jun 28, 2013 at 10:43:30PM -0700, Ben Widawsky wrote: > On Fri, Jun 28, 2013 at 09:55:27AM +0100, Chris Wilson wrote: > > On Thu, Jun 27, 2013 at 04:30:58PM -0700, Ben Widawsky wrote: > > > Pin doesn't fit with PPGTT since the interface doesn't allow for the > > > context for which we want

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-28 Thread Ben Widawsky
On Fri, Jun 28, 2013 at 09:55:27AM +0100, Chris Wilson wrote: > On Thu, Jun 27, 2013 at 04:30:58PM -0700, Ben Widawsky wrote: > > Pin doesn't fit with PPGTT since the interface doesn't allow for the > > context for which we want to pin. > > Nak. Pin still retains it semantics with the gtt and only

Re: [Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-28 Thread Chris Wilson
On Thu, Jun 27, 2013 at 04:30:58PM -0700, Ben Widawsky wrote: > Pin doesn't fit with PPGTT since the interface doesn't allow for the > context for which we want to pin. Nak. Pin still retains it semantics with the gtt and only applies to the gtt. -Chris -- Chris Wilson, Intel Open Source Technol

[Intel-gfx] [PATCH 57/66] drm/i915: Disallow pin with full ppgtt

2013-06-27 Thread Ben Widawsky
Pin doesn't fit with PPGTT since the interface doesn't allow for the context for which we want to pin. Full PPGTT will bring a new "soft pin" interface. The semantics of which will probably take some time to iron out. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/i915_gem.c | 7 +++