Re: [Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-13 Thread Daniel Vetter
On Fri, Oct 09, 2015 at 12:59:44PM +0100, Chris Wilson wrote: > On Fri, Oct 09, 2015 at 12:30:29PM +0100, Tomas Elf wrote: > > On 09/10/2015 08:48, Chris Wilson wrote: > > >On Thu, Oct 08, 2015 at 07:31:37PM +0100, Tomas Elf wrote: > > >>Sometimes the iterated vma objects are NULL apparently. Be aw

Re: [Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-09 Thread Chris Wilson
On Fri, Oct 09, 2015 at 12:30:29PM +0100, Tomas Elf wrote: > On 09/10/2015 08:48, Chris Wilson wrote: > >On Thu, Oct 08, 2015 at 07:31:37PM +0100, Tomas Elf wrote: > >>Sometimes the iterated vma objects are NULL apparently. Be aware of this > >>while > >>iterating and do early exit instead of caus

Re: [Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-09 Thread Tomas Elf
On 09/10/2015 09:33, Daniel Vetter wrote: On Thu, Oct 08, 2015 at 07:31:37PM +0100, Tomas Elf wrote: Sometimes the iterated vma objects are NULL apparently. Be aware of this while iterating and do early exit instead of causing a NULL pointer exception. Signed-off-by: Tomas Elf --- drivers/gp

Re: [Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-09 Thread Tomas Elf
On 09/10/2015 08:48, Chris Wilson wrote: On Thu, Oct 08, 2015 at 07:31:37PM +0100, Tomas Elf wrote: Sometimes the iterated vma objects are NULL apparently. Be aware of this while iterating and do early exit instead of causing a NULL pointer exception. Wrong. -Chris So the NULL pointer excep

Re: [Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-09 Thread Daniel Vetter
On Thu, Oct 08, 2015 at 07:31:37PM +0100, Tomas Elf wrote: > Sometimes the iterated vma objects are NULL apparently. Be aware of this while > iterating and do early exit instead of causing a NULL pointer exception. > > Signed-off-by: Tomas Elf > --- > drivers/gpu/drm/i915/i915_gem.c | 6 +- >

Re: [Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-09 Thread Chris Wilson
On Thu, Oct 08, 2015 at 07:31:37PM +0100, Tomas Elf wrote: > Sometimes the iterated vma objects are NULL apparently. Be aware of this while > iterating and do early exit instead of causing a NULL pointer exception. Wrong. -Chris -- Chris Wilson, Intel Open Source Technology Centre __

[Intel-gfx] [PATCH 5/8] drm/i915: vma NULL pointer check

2015-10-08 Thread Tomas Elf
Sometimes the iterated vma objects are NULL apparently. Be aware of this while iterating and do early exit instead of causing a NULL pointer exception. Signed-off-by: Tomas Elf --- drivers/gpu/drm/i915/i915_gem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gp