[Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-12-29 Thread Ander Conselvan de Oliveira
The documentation for most of the non-static members and structs were missing. Fix that. v2: Fix typos (Durga) v3: Rebase. Fix make docs warnings. Document more. v4: capitilize CRTC; say that the prepare hook is a nop if the DPLL is already enabled; link to struct intel_dpll_hw_state

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-20 Thread Daniel Vetter
On Thu, Oct 20, 2016 at 11:56:07AM +0300, Ander Conselvan De Oliveira wrote: > On Thu, 2016-10-20 at 11:19 +0300, Jani Nikula wrote: > > On Thu, 20 Oct 2016, Daniel Vetter wrote: > > > > > > On Wed, Oct 19, 2016 at 06:29:13PM +0300, Jani Nikula wrote: > > > > > > > > On Wed, 19 Oct 2016, Ander C

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-20 Thread Ander Conselvan De Oliveira
On Thu, 2016-10-20 at 11:19 +0300, Jani Nikula wrote: > On Thu, 20 Oct 2016, Daniel Vetter wrote: > > > > On Wed, Oct 19, 2016 at 06:29:13PM +0300, Jani Nikula wrote: > > > > > > On Wed, 19 Oct 2016, Ander Conselvan De Oliveira > > > wrote: > > > > > > > > On Thu, 2016-10-13 at 15:46 +0200, Da

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-20 Thread Jani Nikula
On Thu, 20 Oct 2016, Daniel Vetter wrote: > On Wed, Oct 19, 2016 at 06:29:13PM +0300, Jani Nikula wrote: >> On Wed, 19 Oct 2016, Ander Conselvan De Oliveira >> wrote: >> > On Thu, 2016-10-13 at 15:46 +0200, Daniel Vetter wrote: >> >> > + /** >> >> > +  * @hw_state: hardware configura

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-19 Thread Daniel Vetter
On Wed, Oct 19, 2016 at 06:29:13PM +0300, Jani Nikula wrote: > On Wed, 19 Oct 2016, Ander Conselvan De Oliveira wrote: > > On Thu, 2016-10-13 at 15:46 +0200, Daniel Vetter wrote: > >> > +/** > >> > + * @hw_state: hardware configuration for the DPLL. > >> "... stored in struct &inte

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-19 Thread Jani Nikula
On Wed, 19 Oct 2016, Ander Conselvan De Oliveira wrote: > On Thu, 2016-10-13 at 15:46 +0200, Daniel Vetter wrote: >> > + /** >> > +  * @hw_state: hardware configuration for the DPLL. >> "... stored in struct &intel_dpll_hw_state." - I love my hyperlinks ;-) > > I'll add that, but I think it's si

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-19 Thread Ander Conselvan De Oliveira
On Thu, 2016-10-13 at 15:46 +0200, Daniel Vetter wrote: > On Tue, Oct 04, 2016 at 03:32:15PM +0300, Ander Conselvan de Oliveira wrote: > > > > The documentation for most of the non-static members and structs were > > missing. Fix that. > > > > v2: Fix typos (Durga) > > > > v3: Rebase. > > Fi

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-13 Thread Daniel Vetter
On Tue, Oct 04, 2016 at 03:32:15PM +0300, Ander Conselvan de Oliveira wrote: > The documentation for most of the non-static members and structs were > missing. Fix that. > > v2: Fix typos (Durga) > > v3: Rebase. > Fix make docs warnings. > Document more. > > Signed-off-by: Ander Conselva

[Intel-gfx] [PATCH 5/7] drm/i915: Update kerneldoc for intel_dpll_mgr.c

2016-10-04 Thread Ander Conselvan de Oliveira
The documentation for most of the non-static members and structs were missing. Fix that. v2: Fix typos (Durga) v3: Rebase. Fix make docs warnings. Document more. Signed-off-by: Ander Conselvan de Oliveira --- Documentation/gpu/i915.rst| 12 +++ drivers/gpu/drm/i915/intel_