Re: [Intel-gfx] [PATCH 5/7] drm/i915: Interrupt driven fences

2016-01-11 Thread Jesse Barnes
On 01/11/2016 11:10 AM, John Harrison wrote: > On 08/01/2016 22:46, Chris Wilson wrote: >> On Fri, Jan 08, 2016 at 06:47:26PM +, john.c.harri...@intel.com wrote: >>> +void i915_gem_request_notify(struct intel_engine_cs *ring, bool >>> fence_locked) >>> +{ >>> +struct drm_i915_gem_request *

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Interrupt driven fences

2016-01-11 Thread John Harrison
On 08/01/2016 22:46, Chris Wilson wrote: On Fri, Jan 08, 2016 at 06:47:26PM +, john.c.harri...@intel.com wrote: +void i915_gem_request_notify(struct intel_engine_cs *ring, bool fence_locked) +{ + struct drm_i915_gem_request *req, *req_next; + unsigned long flags; u32 seqn

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Interrupt driven fences

2016-01-08 Thread Chris Wilson
On Fri, Jan 08, 2016 at 10:14:16PM +, Chris Wilson wrote: > On Fri, Jan 08, 2016 at 06:47:26PM +, john.c.harri...@intel.com wrote: > > From: John Harrison > > > > The intended usage model for struct fence is that the signalled status > > should be set on demand rather than polled. That is

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Interrupt driven fences

2016-01-08 Thread Chris Wilson
On Fri, Jan 08, 2016 at 06:47:26PM +, john.c.harri...@intel.com wrote: > +void i915_gem_request_notify(struct intel_engine_cs *ring, bool fence_locked) > +{ > + struct drm_i915_gem_request *req, *req_next; > + unsigned long flags; > u32 seqno; > > - seqno = req->ring->get_se

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Interrupt driven fences

2016-01-08 Thread Chris Wilson
On Fri, Jan 08, 2016 at 06:47:26PM +, john.c.harri...@intel.com wrote: > From: John Harrison > > The intended usage model for struct fence is that the signalled status > should be set on demand rather than polled. That is, there should not > be a need for a 'signaled' function to be called ev

[Intel-gfx] [PATCH 5/7] drm/i915: Interrupt driven fences

2016-01-08 Thread John . C . Harrison
From: John Harrison The intended usage model for struct fence is that the signalled status should be set on demand rather than polled. That is, there should not be a need for a 'signaled' function to be called everytime the status is queried. Instead, 'something' should be done to enable a signal