Re: [Intel-gfx] [PATCH 5/7] drm/i915/cnl: Don't blindly replace qdiv.

2017-11-14 Thread Manasi Navare
On Tue, Nov 14, 2017 at 11:47:57AM -0800, Rodrigo Vivi wrote: > Accordingly to spec "If Kdiv != 2, then Qdiv must be 1." > but we already handle qdiv values properly and this case here > should be spurious. But instead of blindly replacing let's > warn loudly instead. Because it means something was

[Intel-gfx] [PATCH 5/7] drm/i915/cnl: Don't blindly replace qdiv.

2017-11-14 Thread Rodrigo Vivi
Accordingly to spec "If Kdiv != 2, then Qdiv must be 1." but we already handle qdiv values properly and this case here should be spurious. But instead of blindly replacing let's warn loudly instead. Because it means something was really wrong on initial setup. Cc: Mika Kahola Cc: Manasi Navare C