Re: [Intel-gfx] [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly

2012-04-24 Thread Chris Wilson
On Tue, 24 Apr 2012 12:50:35 -0700, Jesse Barnes wrote: > > + /* "flip pending" bit means done if this bit is set */ > > + I915_WRITE(ECOSKPD, _MASKED_BIT_DISABLE(ECO_FLIP_DONE)); > > + > > Aha. I hope this works across platforms. I don't even know why this

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly

2012-04-24 Thread Daniel Vetter
On Tue, Apr 24, 2012 at 12:50:35PM -0700, Jesse Barnes wrote: > On Tue, 24 Apr 2012 18:31:30 +0100 > Chris Wilson wrote: > > - if (dev->primary->master) { > > - master_priv = dev->primary->master->driver_priv; > > - if (master_priv->sarea_priv) > > -

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly

2012-04-24 Thread Jesse Barnes
On Tue, 24 Apr 2012 18:31:30 +0100 Chris Wilson wrote: > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index b378555..47a540a 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -2307,7 +2307,7 @@ static void i915_irq_prein

[Intel-gfx] [PATCH 5/6] drm/i915: Handle PendingFlip on gen3 robustly

2012-04-24 Thread Chris Wilson
We appear to allow too many pending pageflips as evidenced by an apparent pin-leak. So borrow the pageflip completion logic from i8xx for handling PendingFlip in a robust manner. References: https://bugzilla.kernel.org/show_bug.cgi?id=41882 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i9