Re: [Intel-gfx] [PATCH 5/6] drm/i915/dp: move dp aux ch register init to aux init

2014-03-17 Thread Jani Nikula
On Mon, 17 Mar 2014, Rodrigo Vivi wrote: > I would prefer an else instead of unecessary comparisons and > assignment that will be override.. In general I agree, but see next patch. ;) BR, Jani. > > But anyway it works, so feel free to use: > Reviewed-by: Rodrigo Vivi > > On Fri, Mar 14, 2014

Re: [Intel-gfx] [PATCH 5/6] drm/i915/dp: move dp aux ch register init to aux init

2014-03-17 Thread Rodrigo Vivi
I would prefer an else instead of unecessary comparisons and assignment that will be override.. But anyway it works, so feel free to use: Reviewed-by: Rodrigo Vivi On Fri, Mar 14, 2014 at 11:51 AM, Jani Nikula wrote: > Do a slight rearrangement of the switch to prep for follow-up. > > Signed-of

[Intel-gfx] [PATCH 5/6] drm/i915/dp: move dp aux ch register init to aux init

2014-03-14 Thread Jani Nikula
Do a slight rearrangement of the switch to prep for follow-up. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 42 --- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/int