Re: [Intel-gfx] [PATCH 5/5] tests/kms_psr_sink_crc: Dry run with PSR disabled.

2014-09-08 Thread Daniel Vetter
On Fri, Sep 05, 2014 at 08:51:03AM -0700, Rodrigo Vivi wrote: > I really didn't like this implementation because I'm using the global > variable in the test case. > > So I think also providing a define igt_skip_function_on_dryrun() if > (igt_dry_run) return 0 is more igt like. > > For psr I need

Re: [Intel-gfx] [PATCH 5/5] tests/kms_psr_sink_crc: Dry run with PSR disabled.

2014-09-05 Thread Rodrigo Vivi
I really didn't like this implementation because I'm using the global variable in the test case. So I think also providing a define igt_skip_function_on_dryrun() if (igt_dry_run) return 0 is more igt like. For psr I need a way to run the testcases even when PSR is disabled to know what to expect

Re: [Intel-gfx] [PATCH 5/5] tests/kms_psr_sink_crc: Dry run with PSR disabled.

2014-09-05 Thread Daniel Vetter
On Thu, Sep 04, 2014 at 06:22:51PM -0400, Rodrigo Vivi wrote: > This allows to run tests with psr disabled and know what to expect when > PSR is actually enabled. > > Signed-off-by: Rodrigo Vivi I don't really follow what this is useful for ... Can you please elaborate how this is used and how i

[Intel-gfx] [PATCH 5/5] tests/kms_psr_sink_crc: Dry run with PSR disabled.

2014-09-04 Thread Rodrigo Vivi
This allows to run tests with psr disabled and know what to expect when PSR is actually enabled. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 51e54a7..1380ca4 100644

[Intel-gfx] [PATCH 5/5] tests/kms_psr_sink_crc: Dry run with PSR disabled.

2014-09-04 Thread Rodrigo Vivi
This allows to run tests with psr disabled and know what to expect when PSR is actually enabled. Signed-off-by: Rodrigo Vivi --- tests/kms_psr_sink_crc.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c index 51e54a7..1380ca4 100644