Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 11:12:20AM -0800, Matt Roper wrote: > I think the only thing we need to close on is Ville's concern about the > plane winding up with non-NULL fb and crtc pointers even though a crazy > firmware or bootloader somehow left the plane turned off. I'm not super > familiar with

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Matt Roper
On Thu, Feb 05, 2015 at 06:58:06PM +, Damien Lespiau wrote: > On Thu, Feb 05, 2015 at 10:10:26AM -0800, Matt Roper wrote: > > On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > > > Right now, we get a warning when taking over the firmware fb: > > > > > > [drm:drm_atomic_plane_

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
On Thu, Feb 05, 2015 at 10:10:26AM -0800, Matt Roper wrote: > On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > > Right now, we get a warning when taking over the firmware fb: > > > > [drm:drm_atomic_plane_check] FB set but no CRTC > > > > with the following backtrace: > > > >

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Ville Syrjälä
On Thu, Feb 05, 2015 at 10:10:26AM -0800, Matt Roper wrote: > On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > > Right now, we get a warning when taking over the firmware fb: > > > > [drm:drm_atomic_plane_check] FB set but no CRTC > > > > with the following backtrace: > > > >

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Matt Roper
On Thu, Feb 05, 2015 at 05:22:19PM +, Damien Lespiau wrote: > Right now, we get a warning when taking over the firmware fb: > > [drm:drm_atomic_plane_check] FB set but no CRTC > > with the following backtrace: > > [] drm_atomic_check_only+0x35d/0x510 [drm] > [] drm_atomic_commit+0x17/0

[Intel-gfx] [PATCH 5/5] drm/i915: Fix atomic state when reusing the firmware fb

2015-02-05 Thread Damien Lespiau
Right now, we get a warning when taking over the firmware fb: [drm:drm_atomic_plane_check] FB set but no CRTC with the following backtrace: [] drm_atomic_check_only+0x35d/0x510 [drm] [] drm_atomic_commit+0x17/0x60 [drm] [] drm_atomic_helper_plane_set_property+0x8d/0xd0 [drm_kms_helper]