Re: [Intel-gfx] [PATCH 5/5] drm/i915: Convert execbuf code to use vmas

2013-08-12 Thread Ben Widawsky
On Sat, Aug 10, 2013 at 10:13:20AM +0100, Chris Wilson wrote: > On Fri, Aug 09, 2013 at 10:12:16PM -0700, Ben Widawsky wrote: > > static int > > i915_gem_execbuffer_move_to_gpu(struct intel_ring_buffer *ring, > > - struct list_head *objects) > > +

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Convert execbuf code to use vmas

2013-08-10 Thread Chris Wilson
On Fri, Aug 09, 2013 at 10:12:16PM -0700, Ben Widawsky wrote: > static int > i915_gem_execbuffer_move_to_gpu(struct intel_ring_buffer *ring, > - struct list_head *objects) > + struct list_head *vmas) > { > - struct drm_i915_gem_object *

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Convert execbuf code to use vmas

2013-08-10 Thread Chris Wilson
On Fri, Aug 09, 2013 at 10:12:16PM -0700, Ben Widawsky wrote: > From: Ben Widawsky > > In order to transition more of our code over to using a VMA instead of > an pair - we must have the vma accessible at execbuf time. Up > until now, we've only had a VMA when actually binding an object. > > Th

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Convert execbuf code to use vmas

2013-08-10 Thread Chris Wilson
On Fri, Aug 09, 2013 at 10:12:16PM -0700, Ben Widawsky wrote: > static int > -need_reloc_mappable(struct drm_i915_gem_object *obj) > +need_reloc_mappable(struct i915_vma *vma) > { > - struct drm_i915_gem_exec_object2 *entry = obj->exec_entry; > - return entry->relocation_count && !use_cpu

[Intel-gfx] [PATCH 5/5] drm/i915: Convert execbuf code to use vmas

2013-08-09 Thread Ben Widawsky
From: Ben Widawsky In order to transition more of our code over to using a VMA instead of an pair - we must have the vma accessible at execbuf time. Up until now, we've only had a VMA when actually binding an object. The previous patch helped handle the distinction on bound vs. unbound. This pa