Re: [Intel-gfx] [PATCH 48/59] drm/arc: Drop fb/crtc check in arc_pgu_update

2020-04-24 Thread Sam Ravnborg
Hi Daniel. On Wed, Apr 15, 2020 at 09:40:23AM +0200, Daniel Vetter wrote: > First it's redundant, fb and crtc are only ever both set or not set. > 2nd, the atomic_check code in simple display pipe helpers guarantees > that this never happens. I looked at drm_simple_kms_plane_atomic_check() - whi

[Intel-gfx] [PATCH 48/59] drm/arc: Drop fb/crtc check in arc_pgu_update

2020-04-15 Thread Daniel Vetter
First it's redundant, fb and crtc are only ever both set or not set. 2nd, the atomic_check code in simple display pipe helpers guarantees that this never happens. So nice bugfix for arcpgu driver here, since it was lacking a call to drm_atomic_helper_check_plane_state(). Signed-off-by: Daniel Vett